Skip to content

Conversation

@JacksonBurns
Copy link
Contributor

@JacksonBurns JacksonBurns commented Jun 12, 2024

Bringing this repo back to life!

Add GitHub Actions

GitHub provides free runners that can build these for us, so this PR will add those!
Specifically, we will build on all platforms and (eventually) all versions of Python that we want to support.

Technical Debt Cleanup

Many of the recipes in this repository are no longer needed since we now use the official builds, so this PR will remove them.

Here's the fate of all of the recipes:

  • now on conda-forge/official, removed: gprof2dot, quantities, pyjulia, pydot, openbabel, mopac, julia, coolprop, cclib, cairo, cairocffi, lpsolve55, pyrdl
  • unused, removed: zmats (was originally used for ARC), scoop, py3dmol, py2cairo, pixman, lpsolve, guppy, fontconfig, eigen, pyrms, diffeqpy
  • sticking around, but just removed the windows stuff we don't use: symmetry

Status of remaining packages:

  • symmetry: works on all platforms!

@JacksonBurns

This comment was marked as resolved.

@JacksonBurns

This comment was marked as resolved.

@JacksonBurns

This comment was marked as resolved.

@JacksonBurns

This comment was marked as resolved.

@JacksonBurns

This comment was marked as resolved.

@JacksonBurns

This comment was marked as resolved.

@JacksonBurns JacksonBurns force-pushed the dr_frankenstein branch 2 times, most recently from 141407a to ab5982d Compare June 18, 2024 13:49
@JacksonBurns
Copy link
Contributor Author

@hwpang @rwest this PR is ready now. We need to update the anaconda token on this repo (I will do this) and create a stable branch to merge into to trigger the builds and uploads (I will do this as well). Please let me know how the changes look!

@JacksonBurns JacksonBurns requested review from hwpang and rwest June 28, 2024 15:45
Copy link
Member

@rwest rwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. I'm fine with removing the old stuff. Will this do multiple Python versions? Do we want it to?

@JacksonBurns
Copy link
Contributor Author

Symmetry actually doesn't depend on Python. It is compatible with all versions of Python, in that way. There are no Python recipes left in this repo.

Copy link
Contributor

@hwpang hwpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@JacksonBurns JacksonBurns merged commit d48b233 into main Jun 28, 2024
@JacksonBurns JacksonBurns deleted the dr_frankenstein branch June 28, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants