Skip to content

Fix some of the invalidations reported by SnoopCompile #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix some of the invalidations reported by SnoopCompile #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions src/graph_engine.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,21 +910,17 @@ end
Base.:(==)(left::VariableRef, right::VariableRef) =
left.model == right.model && left.context == right.context && left.name == right.name && left.index == right.index

function Base.:(==)(left::VariableRef, right)
function variable_ref_compare_error(variable::VariableRef, value)
error(
"Comparing Factor Graph variable `$left` with a value. This is not possible as the value of `$left` is not known at model construction time."
"Comparing Factor Graph variable `$variable` with a value `$value`. This is not possible as `$variable` has a probabilistic nature and its value is not known at model construction time."
)
end
Base.:(==)(left, right::VariableRef) = right == left

Base.:(>)(left::VariableRef, right) = left == right
Base.:(>)(left, right::VariableRef) = left == right
Base.:(<)(left::VariableRef, right) = left == right
Base.:(<)(left, right::VariableRef) = left == right
Base.:(>=)(left::VariableRef, right) = left == right
Base.:(>=)(left, right::VariableRef) = left == right
Base.:(<=)(left::VariableRef, right) = left == right
Base.:(<=)(left, right::VariableRef) = left == right
Base.:(==)(variable::VariableRef, value) = variable_ref_compare_error(variable, value)
Base.:(==)(value, variable::VariableRef) = variable_ref_compare_error(variable, value)

Base.isless(variable::VariableRef, value) = variable_ref_compare_error(variable, value)
Base.isless(value, variable::VariableRef) = variable_ref_compare_error(variable, value)

is_proxied(::Type{T}) where {T <: VariableRef} = True()

Expand Down
Loading