changed noise \eta to local variable (instead of global) in inference model.#69
Merged
bvdmitri merged 2 commits intoReactiveBayes:mainfrom Jan 21, 2026
Merged
changed noise \eta to local variable (instead of global) in inference model.#69bvdmitri merged 2 commits intoReactiveBayes:mainfrom
bvdmitri merged 2 commits intoReactiveBayes:mainfrom
Conversation
…ore realistic data genertion function, allowing to compare posteriors to ground truth
There were a few globals, which weren't defined and it was giving errors on fresh notebook run. This commit fixes that. It also fixes all rand function to actually use rng, it was wrong even before this PR apparently.
Member
|
Thanks @skoghoern ! I checked a PR, there were some failing cells due to undefined variables, but that happens in Jupyter notebooks in long sessions ;) I think I fixed those, lets wait for the CI to run and then we can merge |
Contributor
Author
|
sounds good. thanks to you:D |
bvdmitri
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also added new, more realistic data generation function, allowing to compare posteriors to ground truth. Which i showed with the learned F matrix.
In general it allows (at least for me) to better understand what is learned and appreaciate rxinfers opportunities;)