Fix playback position saving when navigating back. #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playback position saving on talking kotlin episode screen has been broken since #471 due to the VM being properly scoped:
onDisposeis called the VM'sviewModelScopehas already been cancelledscopecan no longer launch coroutines to emit the eventCollectEffectlambda in the presenter is never invoked with the event for saving playback positionFixed by keeping tracking of the latest play back position in a Compose state, and dispatching the event to save the latest playback position when the current screen is removed from the backstack.