Add primary associated types to property and binding protocols #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PropertyProtocol - MutablePropertyProtocol - ComposableMutablePropertyProtocol - BindingSource - BindingTargetProvider
Contributor
Author
|
I'm still very irritated that I don't have a solution that doesn't involve duplicating everything in the protocol... |
Contributor
Author
|
Resolves #887 |
mluisbrown
approved these changes
Jan 21, 2025
Contributor
mluisbrown
left a comment
mluisbrown
left a comment
There was a problem hiding this comment.
Looks good 👍 . If you could just fix the one typo (which already existed in the original definition).
Sources/UnidirectionalBinding.swift
Outdated
| extension SignalProducer: BindingSource where Error == Never {} | ||
|
|
||
| #if swift(>=5.7) | ||
| /// Describes an entity which be bond towards. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Describes an entity which be bond towards. | |
| /// Describes an entity which can be bound towards. |
This typo is also in the original below
Contributor
Author
There was a problem hiding this comment.
Done. Fixed it in a couple other spots that seemed incorrect as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the following protocols
Checklist