Open
Conversation
(cherry picked from commit 7cb8776deef91115a2d4a262ea2f5205981276c4)
(cherry picked from commit 71bab05171f157f065a3609bb6824ec0bac3db27)
* Add note to reducer protocol dependency section The discussion #1870 noted that our migration guide could include more of a breadcrumb that migrating to the Dependencies library isn't a simple matter of changing every environment property to a `@Dependency` property. * wip Co-authored-by: Brandon Williams <mbrandonw@hey.com> (cherry picked from commit 1a168e2397981bd54e4c746ba50b92b7b92dfa07)
* `IfLetStore`: ignore view store binding writes to `nil` state * swift-format * wip * add test for filter --------- Co-authored-by: Brandon Williams <mbrandonw@hey.com> (cherry picked from commit 98af2adcb5a6186168a60dd1db834e39a34aa4e1) # Conflicts: # Sources/ComposableArchitecture/Store.swift # Sources/ComposableArchitecture/SwiftUI/IfLetStore.swift # Sources/ComposableArchitecture/ViewStore.swift # Tests/ComposableArchitectureTests/StoreTests.swift
* Add test case for binding action crash * Workaround layout issue * flakey test * wip (cherry picked from commit c3304961646bd6b6fd71e311d48950b1d63bd930) # Conflicts: # Tests/ComposableArchitectureTests/BindingTests.swift
(cherry picked from commit 00738db7b9176588dff08e78de6daa18f7cb3728)
* Make Store.filter internal We're seeing that `@_spi` can still come up in autocomplete. Now Xcode surfaces internal stuff too occasionally, but maybe this will suppress it a bit. * wip * fix (cherry picked from commit b690a617d1366bd36f047e5da5d3185f20daac71)
p4checo
force-pushed
the
cherry-pick-0.50.1
branch
from
0d6f470 to
396ae72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
0.50.1🏷️