Skip to content

Update BlockingFlowableIterable.onNext() to set error before cancel #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Update BlockingFlowableIterable.onNext() to set error before cancel #7789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/io/reactivex/rxjava3/internal/operators/flowable/BlockingFlowableIterable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,12 @@ public void onSubscribe(Subscription s) {
@Override
public void onNext(T t) {
if (!queue.offer(t)) {
// Error must be set first before calling cancel to avoid race
// with hasNext(), which checks for cancel first before checking
// for error.
error = new QueueOverflowException();
SubscriptionHelper.cancel(this);

onError(new QueueOverflowException());
onComplete();
} else {
signalConsumer();
}
Expand Down
Loading