Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions RxSwift/Binder.swift
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,11 @@ public struct Binder<Value>: ObserverType {
/// - parameter scheduler: Scheduler used to bind the events.
/// - parameter binding: Binding logic.
public init<Target: AnyObject>(_ target: Target, scheduler: ImmediateSchedulerType = MainScheduler(), binding: @escaping (Target, Value) -> Void) {
weak var weakTarget = target

self.binding = { event in
self.binding = { [weak target] event in
switch event {
case .next(let element):
_ = scheduler.schedule(element) { element in
if let target = weakTarget {
if let target = target {
binding(target, element)
}
return Disposables.create()
Expand Down
63 changes: 63 additions & 0 deletions Tests/RxSwiftTests/Binder+Tests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,67 @@ extension BinderTests {
XCTAssertNil(e)
}
}

func testBinderDoesNotRetainTarget() {
var target: NSObject? = NSObject()
#if swift(>=6.2)
weak let weakTarget = target
#else
weak var weakTarget = target
#endif

_ = Binder(target!) { (_, _: Int) in }

target = nil

XCTAssertNil(weakTarget)
}

func testBindingDoesNotExecuteAfterTargetDeallocated() {
var target: NSObject? = NSObject()
var bindingExecuted = false

let binder = Binder(target!) { (_, _: Int) in
bindingExecuted = true
}

target = nil
binder.on(.next(1))

RunLoop.current.run(until: Date(timeIntervalSinceNow: 0.1))

XCTAssertFalse(bindingExecuted)
}

func testBindingReceivesCorrectValue() {
let expectation = self.expectation(description: "binding executed")
let target = NSObject()
var receivedValue: Int?

let binder = Binder(target) { (_, value: Int) in
receivedValue = value
expectation.fulfill()
}

binder.on(.next(42))

waitForExpectations(timeout: 1.0)
XCTAssertEqual(receivedValue, 42)
}

func testBindingReceivesCorrectTarget() {
let expectation = self.expectation(description: "binding executed")
let target = NSObject()
var receivedTarget: NSObject?

let binder = Binder(target) { (t, _: Int) in
receivedTarget = t
expectation.fulfill()
}

binder.on(.next(1))

waitForExpectations(timeout: 1.0)
XCTAssertTrue(receivedTarget === target)
}
}
Loading