Merged
Conversation
|
Review changes with Changed Files
|
Member
Author
|
Made this a draft because I forgot to update localization... |
Contributor
|
250KB is too much and causes server crashes
joanise
force-pushed
the
dev.ej/fix-size-limits
branch
from
62f6f55 to
4bba75e
Compare
Member
Author
|
Localization fixed. Ready to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
While our old limits of 30KB/60KB were too low to allow realistic Studio-Web use, 250KB is causing crashes. I can crash the server with a 50kb file, even. So restore the max size for text to 40KB, but since the XML is quite bloated, allow 200KB for .readalong inputs.
While I'm here, I also added the same size limit to the text box, so that cut-and-pasting can't be used as a work around for the limit and bring the crashes back.
Fixes?
Heroku crash warnings we receive once in a while. Hopefully. 🤞
Feedback sought?
Make sure the code is OK.
Priority?
high
Tests added?
Normal use is already covered by CI.
Exceeding the limits is not tested, no.
How to test?
Spin up locally, or use the PR preview, and submit text file text file > 40kb, or .readalong file > 200kb, and see an error toast.
Confidence?
high
Version change?
no