Adding headers in response objects

Author: bksh05

src/controllers/guildRoleHandler.ts

@@ -86,10 +86,21 @@ export async function getGuildRolesHandler(request: IRequest, env: env) {
         { error: response.ROLE_FETCH_FAILED },
         {
           status: 500,
+          headers: {
+            "content-type": "application/json;charset=UTF-8",
+          },
         }
       );
     }
-    return new JSONResponse(response.INTERNAL_SERVER_ERROR, { status: 500 });
+    return new JSONResponse(
+      { error: response.INTERNAL_SERVER_ERROR },
+      {
+        status: 500,
+        headers: {
+          "content-type": "application/json;charset=UTF-8",
+        },
+      }
+    );
   }
 }
 
@@ -111,7 +122,12 @@ export async function getGuildRoleByRoleNameHandler(
     await verifyAuthToken(authHeader, env);
     const role = await getGuildRoleByName(roleName, env);
     if (!role) {
-      return new JSONResponse(response.NOT_FOUND, { status: 404 });
+      return new JSONResponse(response.NOT_FOUND, {
+        status: 404,
+        headers: {
+          "content-type": "application/json;charset=UTF-8",
+        },
+      });
     }
     return new JSONResponse(role);
   } catch (err: any) {
@@ -120,9 +136,20 @@ export async function getGuildRoleByRoleNameHandler(
         { error: response.ROLE_FETCH_FAILED },
         {
           status: 500,
+          headers: {
+            "content-type": "application/json;charset=UTF-8",
+          },
         }
       );
     }
-    return new JSONResponse(response.INTERNAL_SERVER_ERROR, { status: 500 });
+    return new JSONResponse(
+      { error: response.INTERNAL_SERVER_ERROR },
+      {
+        status: 500,
+        headers: {
+          "content-type": "application/json;charset=UTF-8",
+        },
+      }
+    );
   }
 }

tests/unit/handlers/guildRoleHandler.test.ts

@@ -67,7 +67,9 @@ describe("get roles", () => {
     );
     const jsonResponse = await response.json();
     expect(response.status).toBe(500);
-    expect(jsonResponse).toBe(responseConstants.INTERNAL_SERVER_ERROR);
+    expect(jsonResponse).toEqual({
+      error: responseConstants.INTERNAL_SERVER_ERROR,
+    });
   });
 
   it("should return empty array if there is no roles in guild", async () => {
@@ -230,7 +232,9 @@ describe("get role by role name", () => {
     );
     const jsonResponse: { roles: Array<GuildRole> } = await response.json();
     expect(response.status).toBe(500);
-    expect(jsonResponse).toBe(responseConstants.INTERNAL_SERVER_ERROR);
+    expect(jsonResponse).toEqual({
+      error: responseConstants.INTERNAL_SERVER_ERROR,
+    });
   });
 
   it("should return object of id and name corresponding to the role name recieved", async () => {