Main to dev sync (#96) #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding tests for roles endpoint * Feature: Create Discord API Endpoint to Remove Role from User (#82) * add an api endpoint to relete role on discord * revert commits to urls * add test for remove guild role api * remove unwanted changes * add proper response headers * adding tests for roles endpoint * [Feature] Add APIs for fetching role information * removing unnecessary constants * Adding headers in response objects * Adding extra try blocks in utils to handle errors * Throwing errors when something goes wrong * moving test constants to fixtures * changing error type thrown on bad request * Using roles url of discord to get roles details * Raising different PR for /verify string (#94) * raising different PR for /verify string * resolved the comment * fix lint issue * fix lint issue --------- Co-authored-by: Bikash Singh <[email protected]> Co-authored-by: Ritik Jaiswal <[email protected]> Co-authored-by: Sunny Sahsi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding tests for roles endpoint
Feature: Create Discord API Endpoint to Remove Role from User (Feature: Create Discord API Endpoint to Remove Role from User #82)
add an api endpoint to relete role on discord
revert commits to urls
add test for remove guild role api
remove unwanted changes
add proper response headers
adding tests for roles endpoint
[Feature] Add APIs for fetching role information
removing unnecessary constants
Adding headers in response objects
Adding extra try blocks in utils to handle errors
Throwing errors when something goes wrong
moving test constants to fixtures
changing error type thrown on bad request
Using roles url of discord to get roles details
Raising different PR for /verify string (Raising different PR for /verify string #94)
raising different PR for /verify string
resolved the comment
fix lint issue
fix lint issue