Skip to content

Dev to main sync #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2024
Merged

Dev to main sync #247

merged 2 commits into from
Sep 18, 2024

Conversation

PeeyushPrashant
Copy link
Contributor

@PeeyushPrashant PeeyushPrashant commented Sep 16, 2024 •
edited by ankushdharkar
Loading

Date: 16/09/24
Developer Name: @PeeyushPrashant

Related Issues

PR list

Description

  • This PR adds User Id and User Name along with other user details when /user command is used
  • Have changed dummy data to John Doe (as any user can be removed from RDS)
  • Added tests for my changes
  • This feature is behind feature flag

Documentation Updated?

  • Yes
  • No (simple extra field shown in output on discord message)

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
screen-capture.5.webm

@PeeyushPrashant
Added username & userId to /user command (#244)
c5d04ad 
* added username & userId to /user command

* corrected dummy user

* corrected formatting

* user details format correction

* added feature flag
@prakashchoudhary07
Add RDS_SERVERLESS_PUBLIC_KEY to deploy on CD (#248)
c7351dd 
Added RDS_SERVERLESS_PUBLIC_KEY in register-commands-staging action
ankushdharkar
ankushdharkar requested changes Sep 18, 2024
View reviewed changes
@ankushdharkar ankushdharkar merged commit 28d3ea6 into main Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushdharkar ankushdharkar ankushdharkar requested changes

@iamitprakash iamitprakash Awaiting requested review from iamitprakash

@prakashchoudhary07 prakashchoudhary07 Awaiting requested review from prakashchoudhary07

@yesyash yesyash Awaiting requested review from yesyash

Assignees

@PeeyushPrashant PeeyushPrashant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PeeyushPrashant @ankushdharkar @prakashchoudhary07 @iamitprakash