-
Notifications
You must be signed in to change notification settings - Fork 54
feat: display message after running mention each command on Discord #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display message after running mention each command on Discord #252
Conversation
Is your feature under the Feature flag? |
no its not under feature flag |
51cd245
to
1a1db21
Compare
|
Please put it under feature flag first, once it stays in production for more than 2 weeks without any apparent issue then you can remove it, every new feature goes behind dev flag first confirm how you can put feature under feature flag in discord-slash-command i'm not sure |
Can you add a video showing if dev flag affecting the outcome? as you are hard coding the value to true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add you changes under feature flag and also write test for it
b92d39b
to
b54d9c3
Compare
Date: 20-09-2024
Developer Name: Rishi Chaubey
Issue Ticket Number :
/mention-each
command, the first line in the message should say: "Role mentioned: @xyz" #240Description
Implemented a feature to display the message "users with example-unverified roles:" following the execution of the mention each command.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
here is the issue link for the PR
#240