Skip to content

Conversation

RishiChaubey31
Copy link
Member

@RishiChaubey31 RishiChaubey31 commented Sep 19, 2024

Date: 20-09-2024

Developer Name: Rishi Chaubey


Issue Ticket Number :

Description

Implemented a feature to display the message "users with example-unverified roles:" following the execution of the mention each command.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Screenshot 2024-09-20 025542
Screenshot 2024-09-20 025547

Test Coverage

Screenshot 1

Screenshot 2024-10-02 183917

Additional Notes

here is the issue link for the PR
#240

@vinit717
Copy link
Member

Is your feature under the Feature flag?
and, the message says this The users with @developers role are: xyz so what about only a single user with that role

@RishiChaubey31
Copy link
Member Author

Is your feature under the Feature flag? and, the message says this The users with @developers role are: xyz so what about only a single user with that role

no its not under feature flag

@RishiChaubey31 RishiChaubey31 force-pushed the mentionDisplay branch 3 times, most recently from 51cd245 to 1a1db21 Compare September 28, 2024 19:04
@tejaskh3
Copy link
Contributor

tejaskh3 commented Oct 2, 2024

  • please add Issue link
  • Please add test coverage

@shubhdevelop
Copy link
Contributor

shubhdevelop commented Oct 2, 2024

Is your feature under the Feature flag? and, the message says this The users with @developers role are: xyz so what about only a single user with that role

no its not under feature flag

Please put it under feature flag first, once it stays in production for more than 2 weeks without any apparent issue then you can remove it, every new feature goes behind dev flag first

confirm how you can put feature under feature flag in discord-slash-command i'm not sure

@shubhdevelop
Copy link
Contributor

Can you add a video showing if dev flag affecting the outcome? as you are hard coding the value to true

Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add you changes under feature flag and also write test for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When we use /mention-each command, the first line in the message should say: "Role mentioned: @xyz"
4 participants