remove feature flag from mention each user command #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinit717
approved these changes
Oct 16, 2024
Achintya-Chatterjee
approved these changes
Oct 16, 2024
|
Can you please add a video showing the workings of mention each without the feature flag |
vinit717
changed the title
vinit717
added a commit
that referenced
this pull request
Oct 20, 2024
vikhyat187
pushed a commit
to vikhyat187/discord-slash-commands
that referenced
this pull request
Oct 25, 2024
This reverts commit b54d9c3.
prakashchoudhary07
pushed a commit
that referenced
this pull request
Nov 16, 2024
* Discord slash command code to grant AWS access * added test cases for the discord command * added uuid as types * Revert "remove feature flag (#275)" (#281) This reverts commit b54d9c3. * removed uuid, code refactoring and fixed test cases post changes * correcting package.json file * lint fix * code refactoring to call the API outside if/else * Updated the command options to valid one * fix test cases * Fixing test case - changing the return type to Promise<void> * lint fix * Updated the logic of signing JWT into seperate file * added documentation for website backend API * added feature flag to backend API * Updated the backend route to /aws/groups/access * Reverted the register command change * remove package lock changes * added the group id to config file and added more info to the async processing comment * remove the unused import * added feature flag * fix the register command, as the value of ENV variable was being passed as undefined, due to recent change * code refactor and made FF mandatory --------- Co-authored-by: Vinit khandal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 17-10-2024
Developer Name: Rishi Chaubey
Issue Ticket Number
Description
Removed the feature flag from mentionEach command as the flag is not required
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
this is the screen recording without feature flag
general._.Rishi.s.Server.-.Discord.2024-10-17.17-31-15.mp4
this is the screen recording when there was feature flag before
general._.Rishis.Server.-.Discord.2024-10-17.17-25-42.mp4