Skip to content

Conversation

RishiChaubey31
Copy link
Member

@RishiChaubey31 RishiChaubey31 commented Oct 20, 2024

Date: 20-10-24

Developer Name: Rishi Chaubey


Issue Ticket Number

Description

  • A message is displayed whenever user runs mention-each command,
  • Put the feature behind feature flag
  • written required tests for the feature

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Screenshot 2024-10-20 141052

Test Coverage

Screenshot 1

Screenshot 2024-11-04 233859
Screenshot 2024-10-20 141919
Screenshot 2024-10-20 142045

Additional Notes

recording of the whole working of the feature

general._.Rishis.Server.-.Discord.2024-10-29.00-01-26.mp4

@RishiChaubey31 RishiChaubey31 changed the title When we use /mention-each command, the first line in the message should say: "The users with @xyz role are: " To display specific message when used /mention-each command Oct 20, 2024
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the video after the optional argument name is finalize

@vinit717
Copy link
Member

vinit717 commented Nov 4, 2024

Can you add the test coverage not the test passing

@iamitprakash iamitprakash merged commit bd4d987 into Real-Dev-Squad:develop Nov 5, 2024
2 checks passed
@RishiChaubey31 RishiChaubey31 mentioned this pull request Nov 8, 2024
10 tasks
@vinit717 vinit717 mentioned this pull request Nov 8, 2024
12 tasks
@RishiChaubey31 RishiChaubey31 deleted the mentionDisplay branch November 16, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When we use /mention-each command, the first line in the message should say: "Role mentioned: @xyz"
3 participants