feat: ensure team creator is added as a member when creating a team (#153)

* feat: ensure team creator is added as a member when creating a team

* feat: improve mock user creation in team service tests for clarity

---------

Co-authored-by: Amit Prakash <[email protected]>

Author: amit-flx

todo/services/team_service.py

@@ -70,6 +70,17 @@ def create_team(cls, dto: CreateTeamDTO, created_by_user_id: str) -> CreateTeamR
                 )
                 user_teams.append(user_team)
 
+            # Always add the creator as a member if not already in member_ids or as POC
+            if created_by_user_id not in member_ids and created_by_user_id != dto.poc_id:
+                user_team = UserTeamDetailsModel(
+                    user_id=PyObjectId(created_by_user_id),
+                    team_id=created_team.id,
+                    role_id=DEFAULT_ROLE_ID,
+                    created_by=PyObjectId(created_by_user_id),
+                    updated_by=PyObjectId(created_by_user_id),
+                )
+                user_teams.append(user_team)
+
             # Create all user-team relationships
             if user_teams:
                 UserTeamDetailsRepository.create_many(user_teams)

todo/tests/unit/services/test_team_service.py

@@ -94,3 +94,37 @@ def test_get_user_teams_repository_error(self, mock_get_by_user_id):
             TeamService.get_user_teams(self.user_id)
 
         self.assertIn("Failed to get user teams", str(context.exception))
+
+    @patch("todo.services.team_service.TeamRepository.create")
+    @patch("todo.services.team_service.UserTeamDetailsRepository.create_many")
+    @patch("todo.dto.team_dto.UserRepository.get_by_id")
+    def test_creator_always_added_as_member(self, mock_user_get_by_id, mock_create_many, mock_team_create):
+        """Test that the creator is always added as a member when creating a team"""
+        # Patch user lookup to always return a mock user
+        mock_user = type(
+            "User",
+            (),
+            {"id": None, "name": "Test User", "email_id": "[email protected]", "created_at": None, "updated_at": None},
+        )()
+        mock_user_get_by_id.return_value = mock_user
+        # Creator is not in member_ids or as POC
+        creator_id = "507f1f77bcf86cd799439099"
+        member_ids = ["507f1f77bcf86cd799439011"]
+        poc_id = "507f1f77bcf86cd799439012"
+        from todo.dto.team_dto import CreateTeamDTO
+
+        dto = CreateTeamDTO(
+            name="Team With Creator",
+            description="desc",
+            member_ids=member_ids,
+            poc_id=poc_id,
+        )
+        # Mock team creation
+        mock_team = self.team_model
+        mock_team_create.return_value = mock_team
+        # Call create_team
+        TeamService.create_team(dto, creator_id)
+        # Check that creator_id is in the user_team relationships
+        user_team_objs = mock_create_many.call_args[0][0]
+        all_user_ids = [str(obj.user_id) for obj in user_team_objs]
+        self.assertIn(creator_id, all_user_ids)

todo/views/team.py

@@ -42,6 +42,18 @@ def get(self, request: Request):
                 data=fallback_response.model_dump(mode="json"), status=status.HTTP_500_INTERNAL_SERVER_ERROR
             )
 
+    @extend_schema(
+        operation_id="create_team",
+        summary="Create a new team",
+        description="Create a new team with the provided details. The creator is always added as a member, even if not in member_ids or as POC.",
+        tags=["teams"],
+        request=CreateTeamSerializer,
+        responses={
+            201: OpenApiResponse(response=CreateTeamResponse, description="Team created successfully"),
+            400: OpenApiResponse(description="Bad request - validation error"),
+            500: OpenApiResponse(description="Internal server error"),
+        },
+    )
     def post(self, request: Request):
         """
         Create a new team.