Merge pull request #1125 from khushi818/fix/assignee-handle

fixed the bug for assignee patch request

Author: bhtibrewal

controllers/tasks.js

@@ -7,6 +7,7 @@ const { OLD_ACTIVE, OLD_BLOCKED, OLD_PENDING } = TASK_STATUS_OLD;
 const { IN_PROGRESS, BLOCKED, SMOKE_TESTING, ASSIGNED } = TASK_STATUS;
 const { INTERNAL_SERVER_ERROR, SOMETHING_WENT_WRONG } = require("../constants/errorMessages");
 const dependencyModel = require("../models/tasks");
+const userQuery = require("../models/users");
 /**
  * Creates new task
  *
@@ -177,7 +178,12 @@ const updateTask = async (req, res) => {
     if (!task.taskData) {
       return res.boom.notFound("Task not found");
     }
-
+    if (req.body?.assignee) {
+      const user = await userQuery.fetchUser({ username: req.body.assignee });
+      if (!user.userExists) {
+        return res.boom.notFound("User doesn't exist");
+      }
+    }
     await tasks.updateTask(req.body, req.params.id);
     return res.status(204).send();
   } catch (err) {

test/integration/tasks.test.js

@@ -365,6 +365,37 @@ describe("Tasks", function () {
           return done();
         });
     });
+
+    it("Should return 204 if assignee exists", function (done) {
+      chai
+        .request(app)
+        .patch(`/tasks/${taskId}`)
+        .set("cookie", `${cookieName}=${jwt}`)
+        .send({ assignee: `${userData[4].username}` })
+        .end((err, res) => {
+          if (err) {
+            return done(err);
+          }
+          expect(res).to.have.status(204);
+          return done();
+        });
+    });
+
+    it("should return 404 if assignee is not in user db", function (done) {
+      chai
+        .request(app)
+        .patch(`/tasks/${taskId}`)
+        .set("cookie", `${cookieName}=${jwt}`)
+        .send({ assignee: "invaliduser" })
+        .end((err, res) => {
+          if (err) {
+            return done(err);
+          }
+          expect(res).to.have.status(404);
+          expect(res.body.message).to.be.equal("User doesn't exist");
+          return done();
+        });
+    });
   });
 
   describe("GET /tasks/:username", function () {