renames variable to match their description tense

Author: heyrandhir

constants/monitor.js

@@ -1,15 +1,15 @@
-const RESOURCE_CREATED_SUCCEEDED = "Resource created successfully.";
-const RESOURCE_UPDATED_SUCCEEDED = "Resource updated successfully.";
-const RESOURCE_RETRIEVAL_SUCCEEDED = "Resource retrieved successfully.";
+const RESOURCE_CREATED_SUCCESSFULLY = "Resource created successfully.";
+const RESOURCE_UPDATED_SUCCESSFULLY = "Resource updated successfully.";
+const RESOURCE_RETRIEVED_SUCCESSFULLY = "Resource retrieved successfully.";
 const RESOURCE_NOT_FOUND = "Resource not found.";
-const RESOURCE_ALREADY_EXIST = "Resource is already being tracked.";
+const RESOURCE_ALREADY_TRACKED = "Resource is already being tracked.";
 
 const RESPONSE_MESSAGES = {
-  RESOURCE_CREATED_SUCCEEDED,
-  RESOURCE_UPDATED_SUCCEEDED,
-  RESOURCE_RETRIEVAL_SUCCEEDED,
+  RESOURCE_CREATED_SUCCESSFULLY,
+  RESOURCE_UPDATED_SUCCESSFULLY,
+  RESOURCE_RETRIEVED_SUCCESSFULLY,
   RESOURCE_NOT_FOUND,
-  RESOURCE_ALREADY_EXIST,
+  RESOURCE_ALREADY_TRACKED,
 };
 
 module.exports = { RESPONSE_MESSAGES };

controllers/monitor.js

@@ -6,7 +6,8 @@ const {
   getTrackedProgressDocuments,
 } = require("../models/monitor");
 const { RESPONSE_MESSAGES } = require("../constants/monitor");
-const { RESOURCE_CREATED_SUCCEEDED, RESOURCE_UPDATED_SUCCEEDED, RESOURCE_RETRIEVAL_SUCCEEDED } = RESPONSE_MESSAGES;
+const { RESOURCE_CREATED_SUCCESSFULLY, RESOURCE_UPDATED_SUCCESSFULLY, RESOURCE_RETRIEVED_SUCCESSFULLY } =
+  RESPONSE_MESSAGES;
 /**
  * @typedef {Object} TrackedProgressRequestBody
  * @property {string} type - The type of tracked progress ("user" or "task").
@@ -46,7 +47,7 @@ const createTrackedProgressController = async (req, res) => {
   try {
     const data = await createTrackedProgressDocument({ ...req.body });
     return res.status(201).json({
-      message: RESOURCE_CREATED_SUCCEEDED,
+      message: RESOURCE_CREATED_SUCCESSFULLY,
       data,
     });
   } catch (error) {
@@ -109,7 +110,7 @@ const updateTrackedProgressController = async (req, res) => {
     const data = await updateTrackedProgressDocument({ ...req });
     return res.status(200).json({
       data,
-      message: RESOURCE_UPDATED_SUCCEEDED,
+      message: RESOURCE_UPDATED_SUCCESSFULLY,
     });
   } catch (error) {
     if (error instanceof NotFound) {
@@ -161,7 +162,7 @@ const getTrackedProgressController = async (req, res) => {
   try {
     const data = await getTrackedProgressDocuments({ ...req.query });
     return res.status(200).json({
-      message: RESOURCE_RETRIEVAL_SUCCEEDED,
+      message: RESOURCE_RETRIEVED_SUCCESSFULLY,
       data,
     });
   } catch (error) {

models/monitor.js

@@ -9,7 +9,7 @@ const {
   buildQueryToFetchTrackedDoc,
 } = require("../utils/monitor");
 const { RESPONSE_MESSAGES } = require("../constants/monitor");
-const { RESOURCE_NOT_FOUND, RESOURCE_ALREADY_EXIST } = RESPONSE_MESSAGES;
+const { RESOURCE_NOT_FOUND, RESOURCE_ALREADY_TRACKED } = RESPONSE_MESSAGES;
 
 /**
  * Creates a tracked progress document based on the provided data.
@@ -30,7 +30,7 @@ const createTrackedProgressDocument = async (documentData) => {
   const query = buildTrackedProgressQueryByType({ userId, taskId });
   const existingDocumentSnapshot = await query.get();
   if (!existingDocumentSnapshot.empty) {
-    throw new Conflict(RESOURCE_ALREADY_EXIST);
+    throw new Conflict(RESOURCE_ALREADY_TRACKED);
   }
   const timeNow = new Date().toISOString();
   // if not passed, the default frequency of 1 will be used as the frequency