Dev to main sync #1420
Merged
Dev to main sync #1420
+2,385
−276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackend into feat/archive-user-if-not-in-discord
Verify status validation1
…tasks-api Feature/current overdue tasks api
…ackend into fix/qr-code-auth-post
…website-backend into fix/onBoarding31
Refactor: keeping body optional in archiving details in the archiving process
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| router.patch("/", authenticate, authorizeRoles([SUPERUSER]), users.nonVerifiedDiscordUsers); | ||
| router.patch( | ||
| "/", | ||
| authenticate, |
Check failure
Code scanning / CodeQL
Missing rate limiting
added onBoarding status of user more than 31 days
removing one time script to remove tokens
* Add a sample route to test it's working * FEAT:Add functionality to update discord Nickname * CHORE: remove console.log's * TEST: Added for discord-nickname-update controller * TEST: add message object accessible * TEST: Added for setUserDiscordNickname * REFACTOR: added a fixture, removed console.log's
| router.post("/tokens", authenticate, authorizeRoles([SUPERUSER]), users.removeTokens); | ||
| router.patch( | ||
| "/:userId/update-nickname", | ||
| authenticate, |
Check failure
Code scanning / CodeQL
Missing rate limiting
This reverts commit 3423a5f.
Resolve merge conflicts for dev to main sync
| router.patch("/", authenticate, eventsValidator.updateEvent, events.updateEvent); | ||
| router.patch("/end", authenticate, eventsValidator.endActiveEvent, events.endActiveEvent); | ||
| router.post("/:id/peers", authenticate, eventsValidator.addPeerToEvent, events.addPeerToEvent); | ||
| router.patch("/:id/peers/kickout", authenticate, eventsValidator.kickoutPeer, events.kickoutPeer); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| router.get("/:id", eventsValidator.getEventById, events.getEventById); | ||
| router.patch("/", authenticate, eventsValidator.updateEvent, events.updateEvent); | ||
| router.patch("/end", authenticate, eventsValidator.endActiveEvent, events.endActiveEvent); | ||
| router.post("/:id/peers", authenticate, eventsValidator.addPeerToEvent, events.addPeerToEvent); |
Check failure
Code scanning / CodeQL
Missing rate limiting
* FEATURE: add functionality to fetch task base on filter like assignee and task title * FIX : fix assignee filter * FIX : add order by title in status filter * FIX: task size related issue * FIX: order all task at initial state * TEMP * FIX: change variable name * FEATURE: add functionality to fetch task based on filter like assignee and task title * FIX(TEST) : fix failing tests * REFACTOR:change term to title query param * TEST: add test for tasks validator chages * TEST: add test for task utils * TEST: add test for task models changes * TEST: add test for task controller(integration test) * Update test/integration/tasks.test.js --------- Co-authored-by: Pratiyush Kumar <[email protected]>
prakashchoudhary07
requested changes
Aug 22, 2023
* FIX: overdue tasks query issue * FIX: overdue tasks query issue
* Adding isMember param to show membership of the user * reverting script * populating membership details only when flag is set * Adding tests * fixing PR comments: more specific checks for flags * Handling firebase limitation of 30 comparision * PR comments: semantical fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 18/08/2023
Developer Name: @Pratiyushkumar @ravikumar1002 @manish591 @kotesh-arya
PR Number(s):-
Issue Ticket Number:-
Backend changes
Yes
Frontend Changes
No
Database changes
Yes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
No
Deployment notes
Any special instructions for the deployment
Tested in staging
Yes
Also attach their screenshots.
OnBoarding issue - When I run
users/search/?state=ONBOARDINGI get 3 users in staging who have an ONBOARDING state but when I runusers/search/?state=ONBOARDING&time=31dI get No Users found the message so since for onBoarding state users we don't have discord joining date that's why it's giving No Users FoundGithub created at key #1345 - After creating a new account github_created_at key added in user db
Screenshots for PR 1311 ( Archive users if not in discord)
Before: users with roles in_discord and archived false.
API call response:
After: Users with in_discord false's archived role set to true
Feature :
QR scanner
Backend change: Yes
Frontend Change: Yes
API Change : Yes
Video of the working Feature
Screencast from 08-13-2023 12:37:14 AM.webm
Screenshots for 1378 - Update Discord servernames with rds usersname:
Before:
Successful API Response:
After:
