Dev to Main Sync #1786
Merged
Dev to Main Sync #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-Dev-Squad/website-backend into feat/missed-progress-updates
…l-Dev-Squad/website-backend into feat/missed-progress-updates
…1755) * fix: handles failure due to missing discordId * fix : failing test due roles undefined * chore: remove roles import * fix: failing test due to users archived * fix: increase timeout to test * fix: failing test * chore: uncomment a test case line --------- Co-authored-by: Shubham Sharma <[email protected]>
* fix: updates the ts import * chore: remove unwanted space
* feat: adds route and controller functions for missed update * feat: adds tests for controller and validator of missed update script * fix: correct sinon import * fix: update validator test for query params * fix: failing test due modification of shallow copy of test data * chore: remove unnecessary array spreading * chore: fix typo in discord member mock data index * chore: fixes lint issues
* feat: adds route and controller functions for missed update * feat: adds tests for controller and validator of missed update script * fix: correct sinon import * fix: update validator test for query params * fix: failing test due modification of shallow copy of test data * chore: remove unnecessary array spreading * chore: fix typo in discord member mock data index * chore: fixes lint issues * chore: adds role ids to config
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ); | ||
| router.patch("/assign/self", authenticate, invalidateCache({ invalidationKeys: [ALL_TASKS] }), tasks.assignTask); | ||
|
|
||
| router.get("/users/discord", verifyCronJob, getUsersValidator, tasks.getUsersHandler); |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
* fix: minor changes to missed updates * fix: adds an extra status to query * fix: use the correct function for time conversion * chore: update test case data * feat: update response for missed updates details * chore: updates response messages for tests
|
Date: 17 December 2023 Developer Name: @Ajeyakrishna-k PRs
Documentation Updated?
Breaking Changes
Development Tested?
Tested in Staging?
Under Feature Flag
Database Changes
Screenshots
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 14 Dec 2023
Developer Name: @heyrandhir
Issue Ticket Number:-
Description:
Dev to Main Sync
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )