Feat: Implement API for Tracking Orphaned Tasks. #2267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2024
pankajjs
reviewed
Nov 26, 2024
pankajjs
reviewed
Nov 26, 2024
pankajjs
reviewed
Nov 26, 2024
…ng to make it more readable.
10 tasks
pankajjs
suggested changes
Nov 27, 2024
Tests PR is yet to be merged into this, that's why it's failing. |
|
Can you add the test coverage of the files you changed? |
The test cases are included in a separate PR, which will be merged here once the changes are approved. |
byt3quester
reviewed
Nov 27, 2024
Feat: Added tests for orphaned tasks.
… tasks - Replaced individual queries with `fetchIncompleteTasksByUserIds` to fetch tasks in batch for users not in the Discord server. - Improved performance by reducing the number of database queries. - Modified testcases based on the updates.
pankajjs
reviewed
Nov 28, 2024
pankajjs
reviewed
Nov 28, 2024
pankajjs
reviewed
Nov 28, 2024
|
LGTM |
byt3quester
approved these changes
Nov 29, 2024
iamitprakash
approved these changes
Nov 30, 2024
byt3quester
pushed a commit
to byt3quester/website-backend
that referenced
this pull request
Dec 2, 2024
* feat: orphaned tasks API changes. * feat: Added tests for orphaned tasks. * chore: Returned without a block for usersnaptop empty and added spacing to make it more readable. * Refactor: Update fetchOrphanedTasks to use batch query for incomplete tasks - Replaced individual queries with `fetchIncompleteTasksByUserIds` to fetch tasks in batch for users not in the Discord server. - Improved performance by reducing the number of database queries. - Modified testcases based on the updates. * fix: Changed abandoned tasks to orphaned tasks. * Fix: Changed the validation type of orphaned to boolean instead of string.
This was referenced Dec 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 15/11/2024
Developer Name: Vignesh B S
Issue Ticket Number
Closes Real-Dev-Squad/website-dashboard#888
Description
Implemented changes in tasks api for Tracking Orphaned Tasks
tasks?orphaned=true- Retrieves tasks assigned to users who have departed the Discord server.Test Cases
Test cases for the above API are included in a separate PR due to dependency stacking:
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
PRD
Design Doc
Have moved the updateTaskStatusToDone function to models as it was directly interacts with the database and performing operations such as updating task documents. This was also causing circular dependency issues.
API contracts