Feat: Implement APIs for Tracking Departed Users with Assigned Tasks #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinuB-Dev
force-pushed
the
feat/departed-users-api-changes
branch
from
3ba4c10 to
36e067d
Compare
10 tasks
pankajjs
suggested changes
Nov 26, 2024
Updated |
10 tasks
byt3quester
reviewed
Nov 27, 2024
byt3quester
reviewed
Nov 27, 2024
feat: Added test cases for departed users api changes.
…nd filter in-memory - Replaced Firestore query with batch query to fetch incomplete tasks for multiple users at once. - Filter tasks by user IDs and completed statuses in-memory for improved efficiency. - Updated return structure to return an array directly instead of an object with `docs` property. - Updated test cases related to the same.
VinuB-Dev
requested review from
pankajjs,
Achintya-Chatterjee and
byt3quester
byt3quester
approved these changes
Nov 29, 2024
iamitprakash
previously approved these changes
Nov 30, 2024
Achintya-Chatterjee
approved these changes
Nov 30, 2024
iamitprakash
approved these changes
Nov 30, 2024
byt3quester
pushed a commit
to byt3quester/website-backend
that referenced
this pull request
Dec 2, 2024
…eal-Dev-Squad#2268) * feat: Departed users api changes. * feat: Added test cases for departed users api changes. * Refactor: Update fetchIncompleteTasksByUserIds to use batch queries and filter in-memory - Replaced Firestore query with batch query to fetch incomplete tasks for multiple users at once. - Filter tasks by user IDs and completed statuses in-memory for improved efficiency. - Updated return structure to return an array directly instead of an object with `docs` property. - Updated test cases related to the same.
This was referenced Dec 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 15/11/2024
Developer Name: Vignesh B S
Issue Ticket Number
Closes Real-Dev-Squad/website-dashboard#888
Description
Implemented changes in users API for Tracking Departed Users.
users?departed=true- Retrieves users who had a task assigned and have departed the Discord server.Test Cases
Test cases for the above API are included in a separate PR due to dependency stacking:
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
PRD
Design Doc
Have moved the archieveUsers function to models as it was directly interacts with the database and performing operations such as updating task documents. This was also causing circular dependency issues.
Api contracts