Feature : Discord Group edit functionality for super users

controllers/discordactions.js

@@ -10,7 +10,7 @@
 const discordDeveloperRoleId = config.get("discordDeveloperRoleId");
 const discordMavenRoleId = config.get("discordMavenRoleId");
 
-const { setUserDiscordNickname, getDiscordMembers } = discordServices;
+const { setUserDiscordNickname, getDiscordMembers, updateGroupRoleInDiscord } = discordServices;
 
 /**
  * Creates a role
@@ -118,6 +118,67 @@
   }
 };
 
+/**
+ * Updates a group's name or description
+ * @param {Object} req - Express request object
+ * @param {Object} res - Express response object
+ */
+const updateGroupRoleDetails = async (req, res) => {
+  const { groupId } = req.params;
+  let { rolename, description } = req.body;
+  try {
+    const { roleExists, existingRoles } = await discordRolesModel.isGroupRoleExists({ groupId });
+    if (!roleExists) {
+      return res.boom.notFound("Group role not found");
+    }
+
+    const updateData = {};
+    if (rolename) {
+      if (!rolename.startsWith("group-")) {
+        rolename = `group-${rolename}`;
+      }
+
+      const { roleExists: nameExists, existingRoles: nameExistingRoles } =
+        await discordRolesModel.isGroupRoleExists({ rolename });
+      if (nameExists) {
+        const existingId = nameExistingRoles.docs[0].id;
+        if (existingId !== groupId) {
+          return res.status(409).json({ message: "Role already exists!" });
+        }
+      }
+
+      updateData.rolename = rolename;
+    }
+    if (description !== undefined) {
+      updateData.description = description;
+    }
+
+    if (Object.keys(updateData).length === 0) {
+      return res.status(400).json({ message: "Nothing to update" });
+    }
+
+    const roleData = existingRoles.data();
+
+    if (updateData.rolename) {
+      const discordUpdate = await updateGroupRoleInDiscord(
+        roleData.roleid,
+        rolename,
+        req.userData
+      );
+      if (!discordUpdate.success) {
+        return res.boom.badImplementation(discordUpdate.message);
+      }
+    }
+
+    await discordRolesModel.updateGroupRole(updateData, groupId);
+
+    return res.status(200).json({ message: "Group role updated successfully" });
+  } catch (error) {
+    logger.error(`Error while updating group role: ${error}`);
+    return res.boom.badImplementation("Internal server error");
+  }
+};
+
 /**
  * Fetches all group roles or provides paginated results when ?dev=true is passed.
  *
@@ -367,7 +428,7 @@
     const nickNameUpdatedUsers = [];
     let counter = 0;
     for (let i = 0; i < usersToBeEffected.length; i++) {
       const { discordId, username, first_name: firstName } = usersToBeEffected[i];
       try {
         if (counter % 10 === 0 && counter !== 0) {
           await new Promise((resolve) => setTimeout(resolve, 5500));
@@ -383,7 +444,7 @@
           if (message) {
             counter++;
             totalNicknamesUpdated.count++;
             nickNameUpdatedUsers.push(usersToBeEffected[i].id);
           }
         }
       } catch (error) {
@@ -572,5 +633,6 @@
   setRoleToUsersWith31DaysPlusOnboarding,
   getUserDiscordInvite,
   generateInviteForUser,
+  updateGroupRoleDetails,
   deleteGroupRole,
 };

middlewares/validators/discordactions.js

@@ -15,6 +15,21 @@ const validateGroupRoleBody = async (req, res, next) => {
     res.boom.badRequest(error.details[0].message);
   }
 };
+
+const validateGroupRoleUpdateBody = async (req, res, next) => {
+  const schema = Joi.object({
+    rolename: Joi.string().trim(),
+    description: Joi.string().trim(),
+  }).or("rolename", "description");
+
+  try {
+    await schema.validateAsync(req.body);
+    next();
+  } catch (error) {
+    logger.error(`Error validating updateGroupRole payload : ${error}`);
+    res.boom.badRequest(error.details[0].message);
+  }
+};
 const validateMemberRoleBody = async (req, res, next) => {
   const schema = Joi.object({
     userid: Joi.string().trim().required(),
@@ -66,4 +81,5 @@ module.exports = {
   validateMemberRoleBody,
   validateLazyLoadingParams,
   validateUpdateUsersNicknameStatusBody,
+  validateGroupRoleUpdateBody,
 };

routes/discordactions.js

@@ -15,13 +15,15 @@
   syncDiscordGroupRolesInFirestore,
   setRoleToUsersWith31DaysPlusOnboarding,
   deleteGroupRole,
+  updateGroupRoleDetails,
   getPaginatedAllGroupRoles,
 } = require("../controllers/discordactions");
 const {
   validateGroupRoleBody,
   validateMemberRoleBody,
   validateUpdateUsersNicknameStatusBody,
   validateLazyLoadingParams,
+  validateGroupRoleUpdateBody,
 } = require("../middlewares/validators/discordactions");
 const checkIsVerifiedDiscord = require("../middlewares/verifydiscord");
 const checkCanGenerateDiscordLink = require("../middlewares/checkCanGenerateDiscordLink");
@@ -37,6 +39,14 @@
 router.post("/groups", authenticate, checkIsVerifiedDiscord, validateGroupRoleBody, createGroupRole);
 router.get("/groups", authenticate, checkIsVerifiedDiscord, validateLazyLoadingParams, getPaginatedAllGroupRoles);
 router.delete("/groups/:groupId", authenticate, checkIsVerifiedDiscord, authorizeRoles([SUPERUSER]), deleteGroupRole);
+router.patch(
+  "/groups/:groupId",
+  authenticate,
+  checkIsVerifiedDiscord,
+  authorizeRoles([SUPERUSER]),
+  validateGroupRoleUpdateBody,
+  updateGroupRoleDetails
+);
 router.post("/roles", authenticate, checkIsVerifiedDiscord, validateMemberRoleBody, addGroupRoleToMember);
 /**
  * Short-circuit the GET method for this endpoint

services/discordService.js

@@ -140,6 +140,26 @@ const deleteGroupRoleFromDiscord = async (roleId) => {
   }
 };
 
+const updateGroupRoleInDiscord = async (roleId, roleName, userData) => {
+  try {
+    const headers = generateCloudFlareHeaders(userData);
+    const response = await fetch(`${DISCORD_BASE_URL}/roles/${roleId}`, {
+      method: "PATCH",
+      headers,
+      body: JSON.stringify({ rolename: roleName }),
+    });
+
+    if (response.status === 200) {
+      return { success: true };
+    }
+    const data = await response.json();
+    return { success: false, message: data.message };
+  } catch (err) {
+    logger.error("Error updating role on Discord", err);
+    return { success: false, message: "Internal server error" };
+  }
+};
+
 module.exports = {
   getDiscordMembers,
   getDiscordRoles,
@@ -148,4 +168,5 @@ module.exports = {
   removeRoleFromUser,
   setUserDiscordNickname,
   deleteGroupRoleFromDiscord,
+  updateGroupRoleInDiscord,
 };