Skip to content

fix: correct isNewProgress0 logic to check percentCompleted === 0 #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: correct isNewProgress0 logic to check percentCompleted === 0 #2458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions controllers/tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,11 @@ const updateTaskStatus = async (req, res, next) => {
const isCurrentTaskStatusBlock = task.taskData.status === TASK_STATUS.BLOCKED;
const isNewTaskStatusInProgress = status === TASK_STATUS.IN_PROGRESS;
const isNewTaskStatusBlock = status === TASK_STATUS.BLOCKED;
const isCurrProgress100 = parseInt(task.taskData.percentCompleted || 0) === 100;
const isCurrProgress0 = parseInt(task.taskData.percentCompleted || 0) === 0;
const isNewProgress100 = !!req.body.percentCompleted && parseInt(req.body.percentCompleted) === 100;
const isNewProgress0 = !!req.body.percentCompleted !== undefined && parseInt(req.body.percentCompleted) === 0;
const isCurrProgress100 = Number.parseInt(task.taskData.percentCompleted || 0) === 100;
const isCurrProgress0 = Number.parseInt(task.taskData.percentCompleted || 0) === 0;
const isNewProgress100 = !!req.body.percentCompleted && Number.parseInt(req.body.percentCompleted) === 100;
const isNewProgress0 =
req.body.percentCompleted !== undefined && Number.parseInt(req.body.percentCompleted) === 0;

if (
!isCurrProgress100 &&
Expand Down
Loading