refactor: update remaining parseInt to Number.parseInt for ES2015+ co…

[pankajtyagi1601]

…mpliance

Date: 18 Jul 2025

Developer Name: Pankaj Tyagi

---

Issue Ticket Number

N/A – General code modernization based on reviewer feedback in PR #2458

Description

This PR refactors the remaining instances of parseInt to Number.parseInt in the following files for ES2015+ compliance and better code clarity:

• controllers/users.js

• controllers/progresses.js

• controllers/aucion.js

• controllers/discordactions.js

• controllers/profileDiffs.js

• utils/extensionRequests.js

• utils/users.js

• utils/progressess.js

• utils/tasks.js

This follows up on the conversation in PR #2458, where reviewers suggested keeping the bug fix and code modernization in separate pull requests for better scope separation.

Documentation Updated?

• Yes
• No
  N/A – No documentation changes required

Under Feature Flag

• Yes
• No

Database Changes

• Yes
• No

Breaking Changes

• Yes
• No

Development Tested?

• Yes
• No
  Changes tested locally and behaviour remains consistent.

Screenshots

N/A for this refactor.

Test Coverage

Unit and integration tests ran successfully.

Additional Notes

This PR was created in response to reviewer feedback on PR #2458. Keeping code modernization separate from bug fixes makes the review and future rollback process cleaner.

Description by Korbit AI

What change is being made?

Refactor all instances of parseInt usage to Number.parseInt for ES2015+ compliance throughout the codebase.

Why are these changes being made?

This change improves code clarity by adopting a more explicit namespace for parsing integers, aligning with modern JavaScript best practices and ES2015+ standards, ensuring consistency across the project. By using Number.parseInt, it also improves scope clarity by avoiding potential misunderstandings related to the global parseInt function.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[korbit-ai]

Korbit doesn't automatically review large (3000+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Summary by CodeRabbit

• Refactor
  • Updated integer parsing throughout the application to use a consistent method, ensuring improved code clarity and maintainability. No changes to user-facing functionality or behavior.

Walkthrough

All changes systematically replace the use of the global parseInt function with Number.parseInt across various controller and utility files. This update affects integer parsing for pagination, query parameters, and user input, but does not alter any logic, control flow, or exported function signatures.

Changes

Files	Change Summary
controllers/auction.js	Replaced global parseInt with Number.parseInt for item quantity parsing in auctions.
controllers/discordactions.js, controllers/progresses.js, controllers/users.js	Swapped global parseInt with Number.parseInt for pagination parameter parsing in controllers.
controllers/profileDiffs.js	Changed parseInt to Number.parseInt for parsing the size query parameter.
utils/extensionRequests.js, utils/tasks.js, utils/progresses.js	Updated to use Number.parseInt for integer parsing in utility query and pagination functions.
utils/users.js	Replaced parseInt with Number.parseInt for parsing the "days" parameter in user search queries.

Poem

In the warren of code, a change hops through,
Number.parseInt now leads the crew.
No logic was shifted, no flow rearranged,
Just parsing with namespaces, all neatly exchanged.
With every integer safely in sight,
The rabbits rejoice—syntax done right! 🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd129fb and 8d40ebc.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (9)

• controllers/auction.js (1 hunks)
• controllers/discordactions.js (2 hunks)
• controllers/profileDiffs.js (1 hunks)
• controllers/progresses.js (1 hunks)
• controllers/users.js (1 hunks)
• utils/extensionRequests.js (1 hunks)
• utils/progresses.js (1 hunks)
• utils/tasks.js (1 hunks)
• utils/users.js (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: Suvidh-kaushik
PR: Real-Dev-Squad/website-backend#2450
File: services/impersonationRequests.ts:11-11
Timestamp: 2025-06-26T20:08:47.146Z
Learning: In services/impersonationRequests.ts, the functions `updateImpersonationRequest` and `getImpersonationRequestById` are being imported from models/impersonationRequests but appear missing because they exist in previous PRs that need to be merged before this PR. This is expected behavior for dependent PRs and the build failures are temporary.

Learnt from: surajmaity1
PR: Real-Dev-Squad/website-backend#2386
File: test/unit/services/oooRequest.test.ts:9-9
Timestamp: 2025-03-16T05:28:26.722Z
Learning: PRs #2383 and #2386 are related. PR #2383 implements the OOO request feature with the services/oooRequest.ts file, while PR #2386 adds tests for this feature. This creates a dependency where PR #2386 requires PR #2383 to be merged first.

🧬 Code Graph Analysis (2)

utils/users.js (1)

controllers/tasks.js (1)

• searchParams (154-154)

controllers/discordactions.js (2)

controllers/progresses.js (4)

• limit (119-119)
• offset (120-120)
• nextPage (121-121)
• prevPage (122-122)

utils/progresses.js (2)

• limit (136-136)
• offset (137-137)

🔇 Additional comments (7)

controllers/profileDiffs.js (1)

25-25: LGTM: Clean modernization to Number.parseInt

The change from parseInt(size) to Number.parseInt(size) follows ES2015+ standards and maintains identical functionality for parsing the pagination size parameter.

utils/tasks.js (1)

77-81: LGTM: Consistent modernization for pagination parsing

Both changes from parseInt(page) to Number.parseInt(page) and parseInt(size) to Number.parseInt(size) properly modernize the integer parsing while maintaining identical functionality for pagination parameters.

utils/progresses.js (1)

136-137: LGTM: Proper modernization with radix preservation

Both changes from parseInt(size, 10) to Number.parseInt(size, 10) and parseInt(page, 10) to Number.parseInt(page, 10) correctly modernize the integer parsing while preserving the explicit radix parameter for safe decimal parsing.

utils/extensionRequests.js (1)

31-31: LGTM: Clean modernization for size parameter parsing

The change from parseInt(size) to Number.parseInt(size) properly modernizes the integer parsing while maintaining identical functionality for the size parameter transformation.

utils/users.js (1)

220-220: LGTM: Consistent modernization for search parameter parsing

The change from parseInt(value) to Number.parseInt(value) properly modernizes the integer parsing for the "days" search parameter while maintaining identical functionality.

controllers/progresses.js (1)

119-122: Excellent ES2015+ compliance with proper radix usage.

The changes to Number.parseInt are well-implemented with consistent radix parameter usage. This maintains the existing pagination logic while modernizing the code according to ES2015+ standards.

controllers/discordactions.js (1)

130-131: Consistent ES2015+ modernization with proper radix usage.

The changes to Number.parseInt are correctly implemented with consistent radix parameter usage across all pagination parsing operations. This aligns well with similar changes in other controller files like controllers/progresses.js and maintains the existing pagination logic.

Also applies to: 142-143