feat: tests for OOO acknowledgement feature

middlewares/validators/oooRequests.ts

@@ -89,7 +89,6 @@ export const acknowledgeOooRequestValidator = async (
     next();
   } catch (error) {
     const errorMessages = error.details.map((detail) => detail.message);
-    logger.error(`Error while validating request payload : ${errorMessages}`);
     return res.boom.badRequest(errorMessages);
   }
 };

test/fixtures/oooRequest/oooRequest.ts

@@ -167,7 +167,7 @@ export const createOooRequests3 = {
   status: REQUEST_STATE.PENDING
 };
 
-export const acknowledgeOooRequest = {
+export const TestAcknowledgeOooRequest = {
   type: REQUEST_TYPE.OOO,
   status: REQUEST_STATE.APPROVED,
   comment: "OOO request approved as it's emergency."

test/integration/requests.test.ts

@@ -15,7 +15,7 @@ import {
   validOooStatusRequests,
   validOooStatusUpdate,
   createOooRequests2,
-  acknowledgeOooRequest,
+  TestAcknowledgeOooRequest,
   createOooRequests3,
 } from "../fixtures/oooRequest/oooRequest";
 import { createRequest, updateRequest } from "../../models/requests";
@@ -351,7 +351,7 @@ describe("/requests OOO", function () {
       chai
         .request(app)
         .patch(`/requests/${testOooRequest.id}?dev=true`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           expect(res).to.have.status(401);
           expect(res.body.error).to.equal("Unauthorized");
@@ -365,7 +365,7 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/${testOooRequest.id}?dev=false`)
         .set("cookie", `${cookieName}=${superUserToken}`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           if (err) {
             return done(err);
@@ -381,7 +381,7 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/11111111111111?dev=true`)
         .set("cookie", `${cookieName}=${superUserToken}`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           if (err) {
             return done(err);
@@ -397,13 +397,13 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/${testOooRequest.id}?dev=true`)
         .set("cookie", `${cookieName}=${authToken}`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           if (err) {
             return done(err);
           }
           expect(res.statusCode).to.equal(403);
-          // expect(res.body.message).to.equal(UNAUTHORIZED_TO_ACKNOWLEDGE_OOO_REQUEST);
+          expect(res.body.message).to.equal(UNAUTHORIZED_TO_CREATE_OOO_REQUEST);
           done();
         });
     });
@@ -413,7 +413,7 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/${approvedOooRequest.id}?dev=true`)
         .set("cookie", `${cookieName}=${superUserToken}`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           if (err) {
             return done(err);
@@ -429,7 +429,7 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/${rejectedOooRequest.id}?dev=true`)
         .set("cookie", `${cookieName}=${superUserToken}`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           if (err) {
             return done(err);
@@ -445,7 +445,7 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/${onboardingRequest.id}?dev=true`)
         .set("cookie", `${cookieName}=${superUserToken}`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           if (err) {
             return done(err);
@@ -461,7 +461,7 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/${testOooRequest.id}?dev=true`)
         .set("cookie", `${cookieName}=${superUserToken}`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           if (err) {
             return done(err);
@@ -477,7 +477,7 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/${testOooRequest.id}?dev=true`)
         .set("cookie", `${cookieName}=${superUserToken}`)
-        .send({...acknowledgeOooRequest, status: REQUEST_STATE.REJECTED})
+        .send({...TestAcknowledgeOooRequest, status: REQUEST_STATE.REJECTED})
         .end(function (err, res) {
           if (err) {
             return done(err);
@@ -494,7 +494,7 @@ describe("/requests OOO", function () {
         .request(app)
         .patch(`/requests/${testOooRequest.id}?dev=true`)
         .set("cookie", `${cookieName}=${superUserToken}`)
-        .send(acknowledgeOooRequest)
+        .send(TestAcknowledgeOooRequest)
         .end(function (err, res) {
           if (err) return done(err);
           expect(res.statusCode).to.equal(500);

test/unit/middlewares/oooRequests.test.ts

@@ -4,9 +4,9 @@ const { expect } = chai;
 
 import {
   createOooStatusRequestValidator,
-  // acknowledgeOOORequestsValidator,
+   acknowledgeOooRequestValidator,
 } from "./../../../middlewares/validators/oooRequests";
-import { acknowledgeOooRequest, validOooStatusRequests, validOooStatusUpdate } from "../../fixtures/oooRequest/oooRequest";
+import { TestAcknowledgeOooRequest, validOooStatusRequests, validOooStatusUpdate } from "../../fixtures/oooRequest/oooRequest";
 import _ from "lodash";
 
 describe("OOO Status Request Validators", function () {
@@ -91,40 +91,50 @@ describe("OOO Status Request Validators", function () {
     });
   });
 
-  describe.skip("acknowledgeOOORequestsValidator", function () {
+  describe("acknowledgeOOORequestsValidator", function () {
     it("should not validate for an invalid request for invalid request type", async function () {
       req = {
-        body: { ...acknowledgeOooRequest, type: "XYZ"}
+        body: { ...TestAcknowledgeOooRequest, type: "XYZ"},
+        params: { id: "test-id" }
       };
 
-      // await acknowledgeOOORequestsValidator(req, res, nextSpy);
-      expect(nextSpy.notCalled).to.be.true;
+      try {
+        await acknowledgeOooRequestValidator(req as any, res as any, nextSpy);
+      } catch (error) {
+        expect(nextSpy.notCalled).to.be.true;
+      }
     });
 
     it("should not validate for an invalid request if status is incorrect", async function () {
       req = {
-        body: { ...acknowledgeOooRequest, status: "PENDING"}
+        body: { ...TestAcknowledgeOooRequest, status: "PENDING"},
+        params: { id: "test-id" }
       };
 
-      // await acknowledgeOOORequestsValidator(req, res, nextSpy);
-      expect(nextSpy.notCalled).to.be.true;
+      try {
+        await acknowledgeOooRequestValidator(req as any, res as any, nextSpy);
+      } catch (error) {
+        expect(nextSpy.notCalled).to.be.true;
+      }
     });
 
     it("should validate for a valid acknowledge OOO request if comment not provided by superusers", async function() {
       req = {
-        body: _.omit(acknowledgeOooRequest, "comment")
+        body: _.omit(TestAcknowledgeOooRequest, "comment"),
+        params: { id: "test-id" }
       };
       res = {};
-      // await acknowledgeOOORequestsValidator(req, res, nextSpy);
+      await acknowledgeOooRequestValidator(req as any, res as any, nextSpy);
       expect(nextSpy.calledOnce).to.be.true;
     });
 
     it("should validate for a valid acknowledge OOO request", async function() {
       req = {
-        body: acknowledgeOooRequest
+        body: TestAcknowledgeOooRequest,
+        params: { id: "test-id" }
       };
       res = {};
-      // await acknowledgeOOORequestsValidator(req, res, nextSpy);
+      await acknowledgeOooRequestValidator(req as any, res as any, nextSpy);
       expect(nextSpy.calledOnce).to.be.true;
     });
   });