[BUG FIX] Fixed editing of ExceptionProperty inside TwoWayPropertyBindingEditor #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of OptionInfo.Property.ToString() into ExceptionProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for a bug that happens when setting
ExceptionPropertyinsideTwoWayPropertyBinding. It's currently usingoption.ToString(), which returns the default C# ToString() method for this class. The correct implementation should beoption.Property.ToString()Repro steps:
1 - Go to the validation example of Unity-Weld-Examples (inside 5_Validation).
2 - Go to the TwoWayPropertyBinding component inside
Canvas/InputField3 - Set ExceptionProperty value to None.
4 - Try set ExceptionProperty to
ValidationExample.ValidationViewModel.isValid5 - Note that the it sets the value to a weird value
UnityWeld-Editor.BaseBidningEditor+OptionInfo. It will also throw an exception if you hit play.