fix: honor OOO grace window in missed updates flow (#2501)

* fix: honor OOO grace window in missed updates flow

- persist lastOooUntil when users leave OOO across status mutations and reconciler
- backfill historical userStatus documents with a lastOooUntil timestamp
- filter missed updates candidates using the persisted grace-period cutoff

* fix failing tests

* fix: reuse shared post-ooo grace period constant

* fix(user-status): address review feedback for lastOooUntil helpers

- collapse normalizeTimestamp null guards into a single check
- normalize fallback timestamps when resolving post-OOO exits
- keep null vs undefined distinction so Firestore clears lastOooUntil correctly

* feat(users): add API-driven lastOooUntil migration (#2502)

* feat(users): add API-driven lastOooUntil migration

- move the lastOooUntil backfill into userStatus with batched updates
- expose POST /users/migration/update-last-ooo-until behind auth + rate limiting
- reuse controller routing so ops can trigger the migration via API
- cover superuser success and non-superuser rejection in integration tests

* resolve merge conflicts

* resolve merge conflicts

Author: Achintya-Chatterjee

constants/userStatus.ts

@@ -12,3 +12,5 @@ export const statusState = {
 };
 
 export const CANCEL_OOO = "cancelOoo";
+
+export const POST_OOO_GRACE_PERIOD_IN_DAYS = 3;

controllers/users.js

@@ -31,7 +31,7 @@ const {
   USERS_PATCH_HANDLER_SUCCESS_MESSAGES,
 } = require("../constants/users");
 const { addLog } = require("../models/logs");
-const { getUserStatus } = require("../models/userStatus");
+const { getUserStatus, runLastOooUntilMigration } = require("../models/userStatus");
 const config = require("config");
 const { generateUniqueUsername } = require("../services/users");
 const userService = require("../services/users");
@@ -80,6 +80,19 @@ const getUserById = async (req, res) => {
   });
 };
 
+const updateLastOooUntil = async (req, res) => {
+  try {
+    const summary = await runLastOooUntilMigration();
+    return res.status(200).json({
+      message: "lastOooUntil migration executed successfully",
+      data: summary,
+    });
+  } catch (error) {
+    logger.error(`Error while running lastOooUntil migration: ${error}`);
+    return res.boom.badImplementation(INTERNAL_SERVER_ERROR);
+  }
+};
+
 /**
  * Fetches the data about our users
  *
@@ -1185,5 +1198,6 @@ module.exports = {
   isDeveloper,
   getIdentityStats,
   updateUsernames,
+  updateLastOooUntil,
   updateProfile,
 };

models/discordactions.js

@@ -8,7 +8,8 @@ const { findSubscribedGroupIds } = require("../utils/helper");
 const { retrieveUsers } = require("../services/dataAccessLayer");
 const { BATCH_SIZE_IN_CLAUSE } = require("../constants/firebase");
 const { getAllUserStatus, getGroupRole, getUserStatus } = require("./userStatus");
-const { userState } = require("../constants/userStatus");
+const { normalizeTimestamp } = require("../utils/userStatus");
+const { userState, POST_OOO_GRACE_PERIOD_IN_DAYS } = require("../constants/userStatus");
 const { ONE_DAY_IN_MS, SIMULTANEOUS_WORKER_CALLS } = require("../constants/users");
 const userModel = firestore.collection("users");
 const photoVerificationModel = firestore.collection("photo-verification");
@@ -958,6 +959,7 @@ const getMissedProgressUpdatesUsers = async (options = {}) => {
   const stats = {
     tasks: 0,
     missedUpdatesTasks: 0,
+    filteredByOoo: 0,
   };
   try {
     const discordUsersPromise = discordService.getDiscordMembers();
@@ -1031,8 +1033,7 @@ const getMissedProgressUpdatesUsers = async (options = {}) => {
 
     const userIdChunks = chunks(Array.from(usersMap.keys()), FIRESTORE_IN_CLAUSE_SIZE);
     const userStatusSnapshotPromise = userIdChunks.map(
-      async (userIdList) =>
-        await userStatusModel.where("currentStatus.state", "==", userState.OOO).where("userId", "in", userIdList).get()
+      async (userIdList) => await userStatusModel.where("userId", "in", userIdList).get()
     );
     const userDetailsPromise = userIdChunks.map(
       async (userIdList) =>
@@ -1046,7 +1047,13 @@ const getMissedProgressUpdatesUsers = async (options = {}) => {
 
     userStatusChunks.forEach((userStatusList) =>
       userStatusList.forEach((doc) => {
-        usersMap.get(doc.data().userId).isOOO = true;
+        const userStatusData = doc.data();
+        const mappedUser = usersMap.get(userStatusData.userId);
+        if (!mappedUser) {
+          return;
+        }
+        mappedUser.isOOO = userStatusData.currentStatus?.state === userState.OOO;
+        mappedUser.lastOooUntil = userStatusData.lastOooUntil ?? null;
       })
     );
 
@@ -1083,9 +1090,18 @@ const getMissedProgressUpdatesUsers = async (options = {}) => {
 
     await Promise.all(progressCountPromise);
 
+    const gracePeriodCutoff = Date.now() - convertDaysToMilliseconds(POST_OOO_GRACE_PERIOD_IN_DAYS);
     for (const [userId, userData] of usersMap.entries()) {
       const discordUserData = discordUserMap.get(userData.discordId);
       const isDiscordMember = !!discordUserData;
+      const normalizedLastOooUntil = normalizeTimestamp(userData.lastOooUntil);
+      const isWithinGracePeriod = normalizedLastOooUntil !== null && normalizedLastOooUntil >= gracePeriodCutoff;
+
+      if (userData.latestProgressCount === 0 && (userData.isOOO || isWithinGracePeriod)) {
+        stats.filteredByOoo++;
+        usersMap.delete(userId);
+        continue;
+      }
       const shouldAddRole =
         userData.latestProgressCount === 0 &&
         !userData.isOOO &&