Skip to content

Commit b83dcd8

Browse files
chore: Remove unused members and recuiters route and handlers (#2499)
* chore: Remove unused members route and handlers Remove members and recruiters controllers, routes, validators, and related tests to streamline the codebase. This cleanup eliminates unused functionality and improves maintainability. * chore: Deprecate members route and clean up related configurations - Removed the members route configuration from routesCacheTTL in custom-environment-variables.js and default.js. - Updated comments in users.js to reflect the removal of the /members endpoint. --------- Co-authored-by: Prakash Choudhary <[email protected]>
1 parent d7627c0 commit b83dcd8

File tree

17 files changed

+6
-1002
lines changed

17 files changed

+6
-1002
lines changed

config/custom-environment-variables.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,7 @@ module.exports = {
126126
},
127127
},
128128

129-
routesCacheTTL: {
130-
"/members": "ROUTESCACHETTL_MEMBERS",
131-
},
129+
routesCacheTTL: {},
132130

133131
Event100ms: {
134132
APP_ACCESS_KEY: "EVENT_100MS_APP_ACCESS_KEY",

config/default.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,7 @@ module.exports = {
130130
},
131131
},
132132

133-
routesCacheTTL: {
134-
"/members": 900,
135-
},
133+
routesCacheTTL: {},
136134

137135
Event100ms: {
138136
APP_ACCESS_KEY: "EVENT_100MS_APP_ACCESS_KEY",

controllers/members.js

Lines changed: 0 additions & 122 deletions
This file was deleted.

controllers/recruiters.js

Lines changed: 0 additions & 49 deletions
This file was deleted.

middlewares/validators/members.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

middlewares/validators/recruiter.js

Lines changed: 0 additions & 26 deletions
This file was deleted.

models/members.js

Lines changed: 0 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -5,63 +5,6 @@
55

66
const firestore = require("../utils/firestore");
77
const userModel = firestore.collection("users");
8-
const ROLES = require("../constants/roles");
9-
/**
10-
* Fetches the data about our users
11-
* @return {Promise<userModel|Array>}
12-
*/
13-
14-
const fetchUsers = async (queryParams = {}) => {
15-
try {
16-
const { showArchived } = queryParams;
17-
const shouldShowArchived = showArchived === "true";
18-
19-
const query = shouldShowArchived ? userModel : userModel.where(`roles.${ROLES.ARCHIVED}`, "==", false);
20-
const snapshot = await query.get();
21-
22-
const allMembers = [];
23-
24-
if (!snapshot.empty) {
25-
snapshot.forEach((doc) => {
26-
const memberData = doc.data();
27-
const curatedMemberData = {
28-
id: doc.id,
29-
...memberData,
30-
};
31-
curatedMemberData.isMember = !!(memberData.roles && memberData.roles.member);
32-
allMembers.push(curatedMemberData);
33-
});
34-
}
35-
36-
return allMembers;
37-
} catch (err) {
38-
logger.error("Error retrieving members data", err);
39-
throw err;
40-
}
41-
};
42-
43-
/**
44-
* changes the role of a new user to member
45-
* @param userId { String }: User id of user to be modified
46-
* @return { Object }: whether moveToMember was successful or not and whether user is already a member or not
47-
*/
48-
49-
const moveToMembers = async (userId) => {
50-
try {
51-
const userDoc = await userModel.doc(userId).get();
52-
const user = userDoc.data();
53-
if (user?.roles?.member) return { isAlreadyMember: true, movedToMember: false };
54-
const roles = user.roles ? { ...user.roles, member: true } : { member: true };
55-
await userModel.doc(userId).update({
56-
roles,
57-
updated_at: Date.now(),
58-
});
59-
return { isAlreadyMember: false, movedToMember: true };
60-
} catch (err) {
61-
logger.error("Error updating user", err);
62-
throw err;
63-
}
64-
};
658

669
/**
6710
* Fetches the data about our users with roles
@@ -88,32 +31,6 @@ const fetchUsersWithRole = async (role) => {
8831
}
8932
};
9033

91-
/**
92-
* changes the role of a new user to member
93-
* @param userId { String }: User id of user to be modified
94-
* @return { Object }: whether moveToMember was successful or not and whether user is already a member or not
95-
*/
96-
97-
const addArchiveRoleToMembers = async (userId) => {
98-
try {
99-
const userDoc = await userModel.doc(userId).get();
100-
const user = userDoc.data();
101-
if (user?.roles && user.roles[ROLES.ARCHIVED]) return { isArchived: true };
102-
const roles = { ...user.roles, [ROLES.ARCHIVED]: true };
103-
await userModel.doc(userId).update({
104-
roles,
105-
updated_at: Date.now(),
106-
});
107-
return { isArchived: false };
108-
} catch (err) {
109-
logger.error("Error updating user", err);
110-
throw err;
111-
}
112-
};
113-
11434
module.exports = {
115-
moveToMembers,
116-
addArchiveRoleToMembers,
117-
fetchUsers,
11835
fetchUsersWithRole,
11936
};

0 commit comments

Comments
 (0)