chore: remove lastOooUntil migration artifacts and code (#2507)

- drop updateLastOooUntil controller now that prod backfill is done
- delete runLastOooUntilMigration helpers from userStatus.js
- remove POST /users/migration/update-last-ooo-until route
- strip integration tests that exercised the migration endpoint

Author: Achintya-Chatterjee

controllers/users.js

@@ -31,7 +31,7 @@ const {
   USERS_PATCH_HANDLER_SUCCESS_MESSAGES,
 } = require("../constants/users");
 const { addLog } = require("../models/logs");
-const { getUserStatus, runLastOooUntilMigration } = require("../models/userStatus");
+const { getUserStatus } = require("../models/userStatus");
 const config = require("config");
 const { generateUniqueUsername } = require("../services/users");
 const userService = require("../services/users");
@@ -80,19 +80,6 @@ const getUserById = async (req, res) => {
   });
 };
 
-const updateLastOooUntil = async (req, res) => {
-  try {
-    const summary = await runLastOooUntilMigration();
-    return res.status(200).json({
-      message: "lastOooUntil migration executed successfully",
-      data: summary,
-    });
-  } catch (error) {
-    logger.error(`Error while running lastOooUntil migration: ${error}`);
-    return res.boom.badImplementation(INTERNAL_SERVER_ERROR);
-  }
-};
-
 /**
  * Fetches the data about our users
  *
@@ -1198,6 +1185,5 @@ module.exports = {
   isDeveloper,
   getIdentityStats,
   updateUsernames,
-  updateLastOooUntil,
   updateProfile,
 };

models/userStatus.js

@@ -16,22 +16,18 @@ const {
   getNextDayTimeStamp,
   convertTimestampsToUTC,
   resolveLastOooUntil,
-  normalizeTimestamp,
 } = require("../utils/userStatus");
 const { TASK_STATUS } = require("../constants/tasks");
 const userStatusModel = firestore.collection("usersStatus");
 const tasksModel = firestore.collection("tasks");
-const { userState, statusState } = require("../constants/userStatus");
+const { userState } = require("../constants/userStatus");
 const discordRoleModel = firestore.collection("discord-roles");
 const memberRoleModel = firestore.collection("member-group-roles");
 const usersCollection = firestore.collection("users");
-const userFutureStatusCollection = firestore.collection("userFutureStatus");
 const config = require("config");
 const DISCORD_BASE_URL = config.get("services.discordBot.baseUrl");
 const { generateAuthTokenForCloudflare } = require("../utils/discord-actions");
 
-const LAST_OOO_MIGRATION_BATCH_SIZE = 450;
-
 // added this function here to avoid circular dependency
 /**
  *
@@ -130,98 +126,6 @@ const addGroupIdleRoleToDiscordUser = async (userId) => {
   }
 };
 
-const getLatestAppliedOooTimestamp = async (userId) => {
-  const snapshot = await userFutureStatusCollection
-    .where("userId", "==", userId)
-    .where("status", "==", userState.OOO)
-    .where("state", "==", statusState.APPLIED)
-    .get();
-
-  let latestIntervalEnd = null;
-  snapshot.forEach((doc) => {
-    const futureData = doc.data();
-    const candidate = normalizeTimestamp(futureData.endsOn) ?? normalizeTimestamp(futureData.from);
-    if (candidate && (!latestIntervalEnd || candidate > latestIntervalEnd)) {
-      latestIntervalEnd = candidate;
-    }
-  });
-
-  return latestIntervalEnd;
-};
-
-const determineLastOooUntilUpdate = async (docData) => {
-  const currentState = docData.currentStatus?.state;
-  const normalizedExisting = normalizeTimestamp(docData.lastOooUntil);
-
-  if (currentState === userState.OOO) {
-    return docData.lastOooUntil === null ? undefined : null;
-  }
-
-  if (normalizedExisting !== null) {
-    return undefined;
-  }
-
-  const currentUntil = normalizeTimestamp(docData.currentStatus?.until);
-  if (currentUntil) {
-    return currentUntil;
-  }
-
-  return await getLatestAppliedOooTimestamp(docData.userId);
-};
-
-const runLastOooUntilMigration = async () => {
-  const summary = {
-    processed: 0,
-    updated: 0,
-    skipped: 0,
-    failed: 0,
-    failedUserIds: [],
-  };
-
-  try {
-    const snapshot = await userStatusModel.get();
-    let batch = firestore.batch();
-    let batchOperations = 0;
-
-    for (const document of snapshot.docs) {
-      summary.processed++;
-      const docData = document.data();
-
-      try {
-        const updateValue = await determineLastOooUntilUpdate(docData);
-        if (updateValue !== undefined) {
-          batch.update(document.ref, { lastOooUntil: updateValue });
-          batchOperations++;
-          summary.updated++;
-        } else {
-          summary.skipped++;
-        }
-      } catch (error) {
-        summary.failed++;
-        summary.failedUserIds.push(docData.userId);
-        logger.error(
-          `Error while updating lastOooUntil for user ${docData.userId}: ${error.message ?? error.toString()}`
-        );
-      }
-
-      if (batchOperations && batchOperations % LAST_OOO_MIGRATION_BATCH_SIZE === 0) {
-        await batch.commit();
-        batch = firestore.batch();
-        batchOperations = 0;
-      }
-    }
-
-    if (batchOperations) {
-      await batch.commit();
-    }
-
-    return summary;
-  } catch (error) {
-    logger.error(`Error while running last OOO backfill migration: ${error}`);
-    throw error;
-  }
-};
-
 /**
  * @param userId {string} : id of the user
  * @returns {Promise<userStatusModel|string>} : returns id of the deleted userStatus
@@ -868,5 +772,4 @@ module.exports = {
   cancelOooStatus,
   getGroupRole,
   addFutureStatus,
-  runLastOooUntilMigration,
 };

routes/users.js

@@ -15,7 +15,6 @@ const authenticateProfile = require("../middlewares/authenticateProfile");
 const { devFlagMiddleware } = require("../middlewares/devFlag");
 const { userAuthorization } = require("../middlewares/userAuthorization");
 const conditionalMiddleware = require("../middlewares/conditionalMiddleware");
-const { commonRateLimiter } = require("../middlewares/rateLimiting");
 
 router.post("/", authorizeAndAuthenticate([ROLES.SUPERUSER], [Services.CRON_JOB_HANDLER]), users.markUnverified);
 router.post("/update-in-discord", authenticate, authorizeRoles([SUPERUSER]), users.setInDiscordScript);
@@ -80,11 +79,5 @@ router.patch("/rejectDiff", authenticate, authorizeRoles([SUPERUSER]), users.rej
 router.patch("/:userId", authenticate, conditionalMiddleware(userValidator.updateUser), users.updateProfile);
 router.get("/suggestedUsers/:skillId", authenticate, authorizeRoles([SUPERUSER]), users.getSuggestedUsers);
 router.post("/batch-username-update", authenticate, authorizeRoles([SUPERUSER]), users.updateUsernames);
-router.post(
-  "/migration/update-last-ooo-until",
-  authenticate,
-  authorizeRoles([SUPERUSER]),
-  commonRateLimiter,
-  users.updateLastOooUntil
-);
+
 module.exports = router;

test/integration/users.test.js

@@ -28,7 +28,6 @@ const { addJoinData, addOrUpdate } = require("../../models/users");
 const userStatusModel = require("../../models/userStatus");
 const { MAX_USERNAME_LENGTH } = require("../../constants/users.ts");
 const { TASK_STATUS } = require("../../constants/tasks");
-const { userState } = require("../../constants/userStatus");
 const userRoleUpdate = userData[4];
 const userRoleUnArchived = userData[13];
 const userAlreadyMember = userData[0];
@@ -2424,49 +2423,6 @@ describe("Users", function () {
     });
   });
 
-  describe("POST /users/migration/update-last-ooo-until", function () {
-    it("should backfill lastOooUntil for eligible users", async function () {
-      const migrationUser = userData[7];
-      const migrationUserId = await addUser(migrationUser);
-      const twoDaysAgo = new Date().setUTCHours(0, 0, 0, 0) - 2 * 24 * 60 * 60 * 1000;
-
-      await firestore.collection("usersStatus").add({
-        userId: migrationUserId,
-        currentStatus: {
-          state: userState.ACTIVE,
-          message: "",
-          from: twoDaysAgo,
-          until: twoDaysAgo,
-          updatedAt: twoDaysAgo,
-        },
-      });
-
-      const res = await chai
-        .request(app)
-        .post("/users/migration/update-last-ooo-until")
-        .set("cookie", `${cookieName}=${superUserAuthToken}`)
-        .send();
-
-      expect(res).to.have.status(200);
-      expect(res.body.message).to.equal("lastOooUntil migration executed successfully");
-      expect(res.body.data.updated).to.be.greaterThan(0);
-
-      const snapshot = await firestore.collection("usersStatus").where("userId", "==", migrationUserId).limit(1).get();
-      const [statusDoc] = snapshot.docs;
-      expect(statusDoc.data().lastOooUntil).to.equal(twoDaysAgo);
-    });
-
-    it("should reject migration for non super users", async function () {
-      const res = await chai
-        .request(app)
-        .post("/users/migration/update-last-ooo-until")
-        .set("cookie", `${cookieName}=${jwt}`)
-        .send();
-
-      expect(res).to.have.status(401);
-    });
-  });
-
   describe("POST /update-in-discord", function () {
     it("it returns proper response", function (done) {
       chai