Merged
Conversation
* fix: remove feature flag from onboarding extension request features * test: update tests after removing feature flag from onboarding extension
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
|
This is staging proof for pr #2382 |
iamitprakash
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Date: 7 Feb, 2025
Developer Name: @pankajjs @AnujChhikara @mbramani
Issue Ticket Number
Description
@pankajjs's change fixes error handler middleware to send error response.
@mbramani's change removes feature flag from
POST /requests,PUT /requests/id, andPATCH /requests/idendpoints for onboarding extension feature.@AnujChhikara's change removes feature flag from progress api and adds a default size(5) for
GET /extension-requestsendpoint when user does not pass any size.PR going to Sync
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshots
Onboarding Extension FeatureShareX_HRQ93QoxtT.mp4
You we can see we are returning the userdata in the response without the dev flag
Test Coverage
Screenshots
Additional Notes