Dev to Main Sync #2541
Merged
Dev to Main Sync #2541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add migration functionality for applications - Implemented `migrateApplications` controller to handle application migrations based on specified actions. - Added `addIsNewField` method in the model to update applications with a new `isNew` field. - Updated routes to include a new endpoint for triggering migrations. * fix: improve batch update logic in addIsNewField method * refactor: rename migration function and update route for adding 'isNew' field - Renamed `migrateApplications` to `addIsNewFieldMigration` for clarity. - Updated the route to directly call the new migration function without action parameters. * style: format route definition for addIsNewFieldMigration - Reformatted the route definition for better readability by aligning parameters in a multi-line format. * refactor: update addIsNewField logic and improve readability * refactor: streamline addIsNewField logic and enhance batch update process - Removed unnecessary tracking of skipped applications. - Simplified document processing by directly updating all documents in the snapshot. - Improved error handling by mapping document IDs for failed updates.
* refactor: restructure application constants and enhance application creation logic - Updated APPLICATION_STATUS_TYPES to use an object for better clarity and added CHANGES_REQUESTED status. - Introduced APPLICATION_ROLES for role management. - Added new API response messages for application creation and updates. - Refactored addApplication controller to utilize createApplicationService for improved application handling. - Implemented validation for application roles in the application validator. - Added getApplicationByUserId method in the applications model to retrieve applications by user ID. - Created applicationService to encapsulate application creation logic and handle conflicts. - Updated application types to include role and social link structures. * test: add imageUrl to application data in integration and validation tests - Updated integration test to include imageUrl in application creation request. - Modified unit tests for application validator to include imageUrl in rawData for validation scenarios. * refactor: enhance application constants and update application retrieval logic * feat: add new API response message for successful application retrieval
* refactor: restructure application constants and enhance application creation logic - Updated APPLICATION_STATUS_TYPES to use an object for better clarity and added CHANGES_REQUESTED status. - Introduced APPLICATION_ROLES for role management. - Added new API response messages for application creation and updates. - Refactored addApplication controller to utilize createApplicationService for improved application handling. - Implemented validation for application roles in the application validator. - Added getApplicationByUserId method in the applications model to retrieve applications by user ID. - Created applicationService to encapsulate application creation logic and handle conflicts. - Updated application types to include role and social link structures. * test: add imageUrl to application data in integration and validation tests - Updated integration test to include imageUrl in application creation request. - Modified unit tests for application validator to include imageUrl in rawData for validation scenarios. * refactor: enhance application constants and update application retrieval logic * feat: add new API response message for successful application retrieval * test: add unit tests for createApplicationService to validate application creation logic - Implemented tests for various scenarios including successful application creation, conflict errors, and boundary cases based on application creation dates. - Verified correct transformation of payload fields and handling of optional fields. - Ensured error handling and logging for different error scenarios. * refactor: simplify imageUrl assignment in application transformation logic - Removed conditional check for imageUrl and directly assigned it to the transformed object. - This change streamlines the transformation process for application payloads. * test: update createApplicationService test to focus on socialLink handling - Modified the test to specifically check the handling of the optional field socialLink when not provided. - Ensured that imageUrl is correctly assigned from the mock payload during application creation.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* feature flag removed for OOO creation * removed a statement * Revert "feature flag removed for OOO creation" This reverts commit 6685c0c. * changes for feature flag removal * fixed error * errors fixed * everything fixed and checked * developer new tag added on discord * changes * added a comment * fixed IIFE * test added and roles after /verify * added role verification expectations * Add individual role assertions for Developer and New roles in external accounts test * Add assertions for unverified role and individual role checks in external accounts test * Add comprehensive role assertions: unverified removal and negative expectations for Developer/New roles * not equal assertion added * fix: use config for unverified role ID assertion --------- Co-authored-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmailcom> Co-authored-by: Mayank Bansal <[email protected]>
- Deleted the addIsNewFieldMigration controller and its associated method from the applications model. - Removed the related route for triggering the migration, streamlining the applications controller and model.
iamitprakash
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 15 Jan 2026
Developer Name: @AnujChhikara
Issue Ticket Number
isNewfield to applications collection #2538PRs going for sync
Description
isNew: falsefor the old applicationsDocumentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
migration.mp4
Screen.Recording.2026-01-15.at.12.07.06.AM.mov
proof for #2533-
Screencast.from.2026-01-15.20-14-11.mp4