test: implement tests for application update functionality

[AnujChhikara]

Date: 30 Jan 2026

Developer Name: @AnujChhikara

---

Issue Ticket Number

• Create API for image upload for new applications #2565

Description

• Added integration tests for the PATCH /applications/:applicationId endpoint, covering various scenarios including successful updates, validation errors, and authorization checks.
• Enhanced unit tests for the applications controller to validate update logic and error handling.
• Introduced validation tests for application update data to ensure proper request structure and content.
• Updated application model tests to verify correct behavior for update operations under different conditions.

Documentation Updated?

• Yes
• No

Under Feature Flag

• Yes
• No

Database Changes

• Yes
• No

Breaking Changes

• Yes
• No

Development Tested?

• Yes
• No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

[coderabbitai]

Summary by CodeRabbit

• Tests
  • Extended comprehensive test coverage for application update functionality, including validation, authentication, authorization, and conflict prevention (24-hour edit throttling) scenarios.

Walkthrough

This PR adds comprehensive test coverage for the PATCH /applications/:applicationId endpoint across integration, controller, middleware, and model layers. Tests verify successful updates, authorization checks, ownership validation, 24-hour edit conflict detection, and field validation rules.

Changes

Cohort / File(s)	Summary
Integration Tests test/integration/application.test.ts	New test suite for PATCH /applications/:applicationId covering successful updates, 400/401/404/409 error responses, empty body validation, disallowed fields, invalid imageUrl, missing application, unauthenticated requests, unauthorized ownership, and 24-hour edit conflict detection.
Controller Unit Tests test/unit/controllers/applications.test.ts	Extended updateApplication controller tests with separate Success and Error case suites, verifying correct model invocation, logging behavior, error message mapping, and response handling for notFound, unauthorized, tooSoon, and unexpected status scenarios.
Middleware Validation Tests test/unit/middlewares/application-validator.test.ts	Renamed existing feedback validation test suite and added new validateApplicationUpdateData test suite covering allowed fields, URI validation, nested objects, length constraints, numeric bounds, phoneNo trimming, and validation failure paths. Two new validator methods added.
Model Unit Tests test/unit/models/application.test.ts	New ApplicationModel.updateApplication test suite verifying successful updates, notFound when application missing, unauthorized when userId mismatches, and tooSoon conflicts for updates within 24 hours.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• test: add test for the application create flow  #2536: Exercises the same application update validation and status/error constant logic that this PR's tests cover.
• feat: add application feedback submission functionality #2552: Directly overlaps with validateApplicationUpdateData and PATCH /applications feedback route/handler changes tested here.
• feat: Implement Create Application Flow for User Onboarding #2534: Modifies the same validator with role, imageUrl, and status checks that are now being tested.

Suggested reviewers

• iamitprakash

Poem

🐰 Hop, hop, hooray! Tests multiply,
PATCH endpoints now verified and spry,
Authorization guards and edit delays too,
Validation rules in triplicate—we're through!
Coverage blooms like spring carrots anew! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'test: implement tests for application update functionality' is clear, concise, and directly describes the primary change—adding comprehensive tests for application update functionality across multiple test layers.
Description check	✅ Passed	The pull request description is well-structured and related to the changeset, detailing specific changes made to tests for the PATCH endpoint, controller logic, validation, and model behavior, with test coverage evidence included.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch anuj/application-edit-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[MayankBansal12]

@coderabbitai bro review, please go easy on @AnujChhikara

[coderabbitai]

@MayankBansal12, absolutely! I'll review the PR with a constructive approach. Great to see the focus on test coverage for the application update functionality - the screenshots show solid coverage numbers!

Let me dive into the changes and provide helpful feedback. 🚀

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@test/integration/application.test.ts`:
- Around line 359-427: The tests mutate applicationId1 in the first "should
return 200..." case which sets lastEditAt and causes later PATCH validation
tests to get 409 Conflict; fix by isolating tests—either create a fresh
application for each PATCH test or switch the validation tests to use a
different pre-seeded app (e.g., applicationId2 with superUserJwt), update the
tests in the "PATCH /applications/:applicationId" describe block to use the new
application id or create a new application within each it() before sending the
PATCH so the 24-hour edit restriction does not interfere.