chore:remove feature flag from task status#1327
Closed
vaishalimaheshwari2000 wants to merge 2 commits intoRealDevSquad:developfrom
Closed
chore:remove feature flag from task status#1327vaishalimaheshwari2000 wants to merge 2 commits intoRealDevSquad:developfrom
vaishalimaheshwari2000 wants to merge 2 commits intoRealDevSquad:developfrom
Conversation
|
@vaishalimaheshwari2000 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
Ashes47
reviewed
Feb 3, 2025
| beautifiedStatus = 'DONE'; | ||
| } | ||
|
|
||
| // console.log("new :",status); |
Contributor
There was a problem hiding this comment.
Please remove this, this is not a NIT
AnujChhikara
reviewed
Feb 4, 2025
| @@ -19,10 +19,10 @@ type Props = { | |||
| // TODO: remove this after fixing the card beautify status | |||
| const beautifyStatus = (status: string, isDevMode?: boolean) => { | |||
Contributor
There was a problem hiding this comment.
Since we’re no longer using the isDevMode parameter, should we remove it from the function and also update where the function is called?
Contributor
Author
There was a problem hiding this comment.
As you said updated , please review it again
pankajjs
suggested changes
Feb 4, 2025
| const { dev } = router.query; | ||
| const isDevMode = dev === 'true'; | ||
|
|
||
| console.log('status: ', status); |
Contributor
Author
There was a problem hiding this comment.
Updated , please review it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date:
4th February, 2025Developer Name: @vaishalimaheshwari2000
Issue Ticket Number
DONEstatus #1318Description
The task status has been updated to
DONEto align with updated terminology and improve clarity.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes