Addition of the task status dropdown and the extension status button on status site task card

[RishiChaubey31]

Date: 13-03-2025

Developer Name: Rishi Chaubey

---

Issue Ticket Number

• Closes feat : add missing features in Task Card Component #1263

Description

• Integration of task status update button in the task card on Status site
• Its the part of migration of features from my site to status site
• removed the task dropdown modal from the dropdown component
• skipped four tests for removing the modal
• Changing status should not alter the progress bar

Documentation Updated?

• Yes
• No

Under Feature Flag

• Yes
• No

Database Changes

• Yes
• No

Breaking Changes

• Yes
• No

Development Tested?

• Yes
• No

Screenshots

Screenshot 1

migration.mp4

Test Coverage

Screenshot 1

Additional Notes

Summary by CodeRabbit

• New Features

  • Added enhanced task status management with conditional editing interfaces and real-time feedback notifications for both successful updates and errors.
  • Improved the task editing workflow by allowing users to update their own tasks under appropriate conditions.

• Style

  • Refined the visual presentation of task cards with updated typography, spacing, and interactive button effects for a more cohesive user experience.

[vercel]

@RishiChaubey31 is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update several task-related components and style definitions. In the TaskDropDown component, a conditional block activated by isDevMode renders an enhanced UI with extra attributes and a nested model component. The TaskStatusEditMode component now incorporates a new mutation hook for self task updates and enhanced toast notifications. The task card rendering logic in index.tsx is modified to leverage additional user data for conditionally enabling the edit interface. Additional CSS classes are introduced in the module stylesheet, and new status message constants are added to the constants file.

Changes

File(s)	Change Summary
src/components/tasks/TaskDropDown.tsx	Added a conditional isDevMode block that renders an enhanced label, select dropdown (with testing attributes), and includes the TaskDropDownModel component with extra props.
src/components/tasks/card/TaskStatusEditMode.tsx, src/components/tasks/card/index.tsx	Introduced a new mutation hook useUpdateSelfTaskMutation; updated the task status updating flow to conditionally execute self task updates with toast notifications; enhanced user data handling to conditionally render the edit interface based on dev mode and user ownership.
src/components/tasks/card/card.module.scss	Added new CSS classes (.cardPurposeAndStatusFont, .cardPurposeText, .taskStatusDateAndPurposeContainer, .taskStatusUpdate) to improve styling for fonts, layout, and button interactions.
src/constants/constants.ts	Added two new status constants: STATUS_UPDATE_SUCCESSFUL and STATUS_UPDATE_ERROR for use in task status update notifications.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant TSE as TaskStatusEditMode
    participant API as Task API Mutation
    participant Toast as Toast Notifications

    U->>TSE: Change task status
    alt isDevMode & isSelfTask true
        TSE->>API: execute updateSelfTask
    else
        TSE->>API: execute updateTask
    end
    API-->>TSE: return response (success/error)
    alt Success
        TSE->>Toast: Trigger success notification
    else Failure
        TSE->>Toast: Trigger error notification
    end

Loading

Suggested reviewers

• AnujChhikara
• iamitprakash

Poem

I'm a rabbit on the run,
Hopping through code under the sun,
With dropdowns and tasks shining anew,
Bugs take a leap like morning dew,
Celebrating changes with a joyful run! 🐇✨

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (4)

src/components/tasks/TaskDropDown.tsx (1)

105-138: Enhanced UI for development mode looks good

The conditional rendering for development mode provides a more styled interface with proper test attributes. This implementation allows for different UIs between development and production environments, which is useful for testing and development purposes.

One minor suggestion: consider extracting the common dropdown code between both rendering paths to avoid duplication. The main differences are just the styling classes and the label test attributes.

src/components/tasks/card/index.tsx (3)

547-553: Consider using a more descriptive variable name.

The conditional class name assignment works correctly, but the class name taskStatusDateAndPurposeContainer doesn't clearly convey why it's different from taskStatusAndDateContainer in dev mode.

-                className={
-                    isDevMode
-                        ? styles.taskStatusDateAndPurposeContainer
-                        : styles.taskStatusAndDateContainer
-                }
+                className={
+                    isDevMode
+                        ? styles.taskStatusDatePurposeDevContainer
+                        : styles.taskStatusAndDateContainer
+                }

---

580-605: Consider refactoring the conditional rendering logic.

The code now conditionally renders the TaskStatusEditMode component when not in dev mode, but you're still passing isDevMode as a prop. This separation creates duplication with the dev mode rendering block later in the component.

-                {!isDevMode && (
-                    <div className={styles.taskStatusEditMode}>
-                        {isEditable ? (
-                            <TaskStatusEditMode
-                                task={editedTaskDetails}
-                                setEditedTaskDetails={setEditedTaskDetails}
-                                isDevMode={isDevMode}
-                            />
-                        ) : (
-                            <div className={styles.statusContainer} style={{}}>
-                                <p className={styles.cardSpecialFont}>
-                                    Status:
-                                </p>
-                                <p
-                                    data-testid="task-status"
-                                    className={styles.statusText}
-                                >
-                                    {beautifyStatus(
-                                        cardDetails.status,
-                                        isDevMode
-                                    )}
-                                </p>
-                            </div>
-                        )}
-                    </div>
-                )}

Consider creating a reusable renderTaskStatusComponent function to avoid duplication.

---

589-589: Remove unnecessary empty style object.

Both instances of the status container have an empty style object that doesn't serve any purpose.

-                            <div className={styles.statusContainer} style={{}}>
+                            <div className={styles.statusContainer}>

Also applies to: 658-658

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b9d9182 and e7c8d20.

📒 Files selected for processing (5)

• src/components/tasks/TaskDropDown.tsx (2 hunks)
• src/components/tasks/card/TaskStatusEditMode.tsx (4 hunks)
• src/components/tasks/card/card.module.scss (2 hunks)
• src/components/tasks/card/index.tsx (5 hunks)
• src/constants/constants.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build (18.x)

🔇 Additional comments (13)

src/constants/constants.ts (1)

9-10: LGTM - Nice addition of status notification constants

The addition of these status message constants is a good practice for maintaining consistent messaging throughout the application. Having them centralized in the constants file will make it easier to maintain and update messages in the future.

src/components/tasks/TaskDropDown.tsx (1)

4-4: LGTM - Appropriate style import added

Good addition of the style import that will be used for the new dev mode UI elements.

src/components/tasks/card/TaskStatusEditMode.tsx (5)

9-11: LGTM - Added mutation hook for self task updates

Good addition of the useUpdateSelfTaskMutation hook alongside the existing task update mutation.

---

14-19: LGTM - Added necessary imports for notifications

Good addition of the status update constants and toast functionality for providing user feedback.

---

25-25: LGTM - Added isSelfTask prop to Props interface

Good addition of the optional isSelfTask prop to allow for conditional behavior based on whether the task belongs to the current user.

---

49-50: LGTM - Added required hooks and constants

Good setup of the updateSelfTask mutation hook and toast type constants.

---

107-107: LGTM - Conditional StatusIndicator rendering

Good conditional rendering of the StatusIndicator component based on the isDevMode flag. This provides appropriate UI feedback in production while hiding it in development mode.

src/components/tasks/card/card.module.scss (3)

94-102: LGTM - Added styles for purpose and status text

Good addition of styles for task purpose and status fonts. The color choices and font sizes are consistent with the application's design.

---

260-267: LGTM - Added container styles for task status, date, and purpose

The grid layout provides a clean way to organize the task information with appropriate spacing and alignment.

---

273-289: LGTM - Added well-styled task status update button

The task status update button styling looks good with appropriate hover effects and transitions. The border, padding, and color choices are well-defined.

src/components/tasks/card/index.tsx (3)

76-76: Good data extraction from useUserData hook.

You've now extracted both data and isUserAuthorized from the useUserData hook, which allows you to access the current user's information (specifically username) for task ownership verification.

---

269-270: Good addition of task and user relationship checks.

These new variables improve the logic readability and make the task editing permissions clearer:

• isSelfTask checks if the current user is the assignee
• isVerifiedTask checks if the task is in VERIFIED status

This supports the conditional rendering logic later in the component.

---

651-656: New conditional rendering improves user access control.

The updated logic now allows users to edit their own task statuses in development mode if they are the task assignee and the task is not verified. This is a good improvement for user experience and testing.

[AnujChhikara]

hello @RishiChaubey31

• do you have any design doc for this feature?
• also please add test coverage stats

[MayankBansal12]

@RishiChaubey31 Please update the PR title