Skip to content

chore: remove feature flag from mobile page #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamitprakash merged 2 commits into from
Jan 6, 2026
Merged

chore: remove feature flag from mobile page #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75570f
chore: remove feature flag from mobile page
MayankBansal12 Mar 21, 2025
785dcf5
fix: naming for mobile route test
MayankBansal12 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions app/routes/mobile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ export default class MobileRoute extends Route {
@service toast;
@service router;

beforeModel(transition) {
if (transition?.to?.queryParams?.dev !== 'true') {
this.router.transitionTo('/page-not-found');
}
}

async model() {
try {
const response = await fetch(SELF_USER_PROFILE_URL, {
Expand Down
26 changes: 4 additions & 22 deletions tests/unit/routes/mobile-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,16 @@ module('Unit | Route | mobile', function (hooks) {
hooks.beforeEach(function () {
this.fetchStub = sinon.stub(window, 'fetch');
this.route = this.owner.lookup('route:mobile');
sinon.stub(this.route.router, 'transitionTo');
});

hooks.afterEach(function () {
this.fetchStub.restore();
sinon.restore();
});

test('redirects to 404 page if dev flag is not present', function (assert) {
const transition = { to: { queryParams: { dev: 'false' } } };

this.route.beforeModel(transition);

assert.ok(
this.route.router.transitionTo.calledOnceWith('/page-not-found'),
'Redirected to /page-not-found when dev is not true',
);
});

test('allows access when dev flag is true', function (assert) {
const transition = { to: { queryParams: { dev: 'true' } } };

this.route.beforeModel(transition);

assert.ok(
this.route.router.transitionTo.notCalled,
'No redirection occurs when dev query param is true',
);
test('mobile route exists and is accessible', function (assert) {
assert.expect(1);
const route = this.owner.lookup('route:mobile');
assert.ok(route, 'The mobile route exists');
});

test('it fetches user profile and returns userId if API responds with 200', async function (assert) {
Expand Down