Skip to content

chore: remove dev flag from profile page #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamitprakash merged 3 commits into from
Jan 6, 2026
Merged

chore: remove dev flag from profile page #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af747ba
chore: remove dev flag from profile page
MayankBansal12 Jan 1, 2026
403499d
fix: add test description
MayankBansal12 Jan 1, 2026
5cc31e0
fix: naming for profile route test
MayankBansal12 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions app/controllers/profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,7 @@ const BASE_URL = APPS.API_BACKEND;

export default class ProfileController extends Controller {
@service toast;
@service router;
get isDev() {
if (
this.router.currentRoute &&
this.router.currentRoute.queryParams.dev === 'true'
) {
return this.router.currentRoute.queryParams.dev;
}
return false;
}

get imageUploadUrl() {
return `${BASE_URL}/users/picture`;
}
Expand Down
7 changes: 1 addition & 6 deletions app/routes/profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,7 @@ const BASE_URL = APPS.API_BACKEND;
export default class ProfileRoute extends Route {
@service toast;
@service fastboot;
@service router;
beforeModel(transition) {
if (transition?.to?.queryParams?.dev !== 'true') {
this.router.transitionTo('/page-not-found');
}
}

async model() {
try {
const res = await fetch(`${BASE_URL}/users/isDeveloper`, {
Expand Down
25 changes: 3 additions & 22 deletions tests/unit/routes/profile-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,15 @@ module('Unit | Route | profile', function (hooks) {
hooks.beforeEach(function () {
this.fetchStub = sinon.stub(window, 'fetch');
this.route = this.owner.lookup('route:profile');
sinon.stub(this.route.router, 'transitionTo');
});

hooks.afterEach(function () {
this.fetchStub.restore();
sinon.restore();
});

test('redirects to 404 page if dev flag is not present', function (assert) {
const transition = { to: { queryParams: { dev: 'false' } } };

this.route.beforeModel(transition);

assert.ok(
this.route.router.transitionTo.calledOnceWith('/page-not-found'),
'Redirected to /page-not-found when dev is not true',
);
});

test('allows access when dev flag is true', function (assert) {
const transition = { to: { queryParams: { dev: 'true' } } };

this.route.beforeModel(transition);

assert.ok(
this.route.router.transitionTo.notCalled,
'No redirection occurs when dev query param is true',
);
test('profile route exists and is accessible', function (assert) {
let route = this.owner.lookup('route:profile');
assert.ok(route, 'Test the route exists and is accessible');
});

test('it fetches and transforms model data correctly', async function (assert) {
Expand Down