Skip to content

Conversation

@ravikumar1002
Copy link
Contributor

@ravikumar1002 ravikumar1002 commented Aug 3, 2023

Issue : #538

What is the change?

Added red flag if user GitHub account created within 1 year and if user Github account is more then 1 year then it'll show
in grey color

  • Make a utility function that will give you the difference between a start date and an end date. The return value will be an object with the key of years and months.
  • showed message according to GitHub created an account.

Backend changes

RealDevSquad/website-backend#1362

Frontend UI test

issue: It's hard, so created new ticket #558

Is Development Tested?

  • Yes

image
image

Before :

image

After :

image
image
image

github-created-at-feature-video.mp4

@sahsisunny
Copy link
Contributor

This PR depends on another backend PR, right? Can you mention it in the main description?

Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@ravikumar1002
Copy link
Contributor Author

This PR depends on another backend PR, right? Can you mention it in the main description?

Ok

@ravikumar1002
Copy link
Contributor Author

ravikumar1002 commented Aug 4, 2023

Tests?

There is no setup for testing currently.

@vinit717
Copy link
Member

vinit717 commented Aug 4, 2023

Tests?

There is no setup for testing currently.

without test, no PR is getting merged if you can't ask @ankushdharkar for this

@ravikumar1002
Copy link
Contributor Author

Tests?

There is no setup for testing currently.

without test, no PR is getting merged if you can't ask @ankushdharkar for this

but there is no test for this repo, I asked sunny for this previously, and every PR getting merged without testing for this with the development test

@ravikumar1002 ravikumar1002 requested a review from vinit717 August 7, 2023 07:45
kotesh-arya
kotesh-arya previously approved these changes Aug 9, 2023
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a video for the flow?

@ravikumar1002
Copy link
Contributor Author

Can you provide a video for the flow?

Done

@ravikumar1002 ravikumar1002 requested a review from vinit717 August 9, 2023 17:32
@sahsisunny sahsisunny merged commit f8a769f into RealDevSquad:develop Aug 15, 2023
@rohan09-raj rohan09-raj mentioned this pull request Aug 17, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants