migrate from yarn to pnpm package manager by Devashish08 · Pull Request #991 · RealDevSquad/website-www

Devashish08 · 2025-01-31T15:45:25Z

Date: 21-01-2025

Developer Name: @Devashish08

Issue Ticket Number:-

Closes Use pnpm as package manager #969

Description:

migrate from yarn to pnpm package manager

Is Under Feature Flag

Yes
No

Database changes

Yes
No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

Yes
No

Is Development Tested?

Yes
No

Tested in staging?

Yes
No

Add relevant Screenshot below ( e.g test coverage etc. )

RishiChaubey31 · 2025-01-31T16:12:56Z

Please fix the formatting of the PR !

Devashish08 · 2025-01-31T17:33:24Z

Please fix the formatting of the PR !

Fixed

RishiChaubey31 · 2025-01-31T18:34:30Z

Please fix the formatting of the PR !

Fixed

Well this is not the right PR format , I would suggest you to take some idea from the other open PR's on this repo

app/controllers/live.js

Devashish08 · 2025-01-31T18:48:21Z

Please fix the formatting of the PR !

Fixed

Please fix the formatting of the PR !

Fixed

Well this is not the right PR format , I would suggest you to take some idea from the other open PR's on this repo

this issue was raised by ankush and he has assign it to me can see issue number 969 fo it thats why i have write this way

.github/workflows/continuous-integration.yml

pankajjs · 2025-02-01T19:32:38Z

Please fix the title. It should not be start with feat: as this is not a feature.

This is the part of issue not PR description

Devashish08 · 2025-02-02T09:08:42Z

Please fix the title. It should not be start with feat: as this is not a feature.

This is the part of issue not PR description

fixed

pankajjs

Left comments

.github/workflows/continuous-integration.yml

.npmrc

* feat: migrate from yarn to pnpm package manager * docs: update documentation for pnpm migration * chore: remove unrelated changes to live.js * chore: restore helpful comments in CI workflow * chore: trigger CI * chore: trigger CI

* Dev to Main Sync (#973) * [My Site Migration] Identity Linking get started page (#965) * resolve merge commits * feat: add get started page * remove: unused auth url * fix: css for get started on identity page * feat: add identity page behind feature flag * nit: remove unwanted .DS_store --------- Co-authored-by: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com> * [My Site Migration] Identity Linking step1 page (#966) * resolve merge commits * feat: add get started page * remove: unused auth url * fix: css for get started on identity page * feat: add identity page behind feature flag * feat: setp1 page in identity linking * remove: unused redirect-auth util * Remove .DS_Store files from repository * feat: add varaible css * feat: add varaible css * refactor(970): moves notices for joining to its own component (#972) * feat(970): moves notices for joining to its own component We were copying the same notice for joining in two places. This moves it to its own component, so future changes are easier. * refactor(970): added review changes: year - 2024 * refactor(970): fixed messaging for joining --------- Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> * [My Site Migration] Identity Linking step2,3 page (#967) * resolve merge commits * feat: add get started page * remove: unused auth url * fix: css for get started on identity page * feat: add identity page behind feature flag * feat: setp1 page in identity linking * remove: unused redirect-auth util * Remove .DS_Store files from repository * feat: add varaible css * feat: add varaible css * feat: add step2 on identity linking page * feat: add step2 and step3 page * feat: add reload step * feat: add varaible css --------- Co-authored-by: TEJAS <98630752+tejaskh3@users.noreply.github.com> Co-authored-by: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> * fix:lint issues * Merge pull request #983 from MayankBansal12/migrate/user-status-pr-1 [My Site Migration] user status feature (Part - 1) * [My Site Migration] migration of profile page [PR-2] (#979) * basic setup and images and svg file * profile route and controller * changed urls.js file * reverted sinon package and fixed css * fixes of urls and yarn.lock and package.json file * changed toast import * moved profile fields to inside constants * resolve merge conflicts * [My Site Migration] user status feature (Part - 2) (#984) * feat: add user status modal, controller for status * refactor: use constants for messages, urls, modify naming * chore: remove extra user_states in status modal * refactor: get current status method in status modal * refactor: status update for dev method * test: simulate mock inViewport for members data test --------- Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> * [My Site Migration] user status feature (Part - 3) (css) (#985) * feat: add css styles for user status component and modal * fix: styles for user status, status modal for mobile responsiveness * fix: remove duplicate css variables * [My Site Migration] user status feature (Part -4) (tests) (#977) * add integration tests for user-status components * fix set prop error and modify test case in status modal * add unit test for status route and component * add unit test for dateConversion, redirectAuth utils * fix: update test for user status, remove redirectAuth test * fix: status naming in user status component test --------- Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com> Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> * migrate from yarn to pnpm package manager (#991) * feat: migrate from yarn to pnpm package manager * docs: update documentation for pnpm migration * chore: remove unrelated changes to live.js * chore: restore helpful comments in CI workflow * chore: trigger CI * chore: trigger CI --------- Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> Co-authored-by: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Mayank Bansal <mayankbansal125@gmail.com> Co-authored-by: Suvidh-kaushik <127885995+Suvidh-kaushik@users.noreply.github.com> Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com> Co-authored-by: DEVASHISH <devashish.cs025@gmail.com>

* Merge pull request #983 from MayankBansal12/migrate/user-status-pr-1 [My Site Migration] user status feature (Part - 1) * [My Site Migration] migration of profile page [PR-2] (#979) * basic setup and images and svg file * profile route and controller * changed urls.js file * reverted sinon package and fixed css * fixes of urls and yarn.lock and package.json file * changed toast import * moved profile fields to inside constants * resolve merge conflicts * [My Site Migration] user status feature (Part - 2) (#984) * feat: add user status modal, controller for status * refactor: use constants for messages, urls, modify naming * chore: remove extra user_states in status modal * refactor: get current status method in status modal * refactor: status update for dev method * test: simulate mock inViewport for members data test --------- Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> * [My Site Migration] user status feature (Part - 3) (css) (#985) * feat: add css styles for user status component and modal * fix: styles for user status, status modal for mobile responsiveness * fix: remove duplicate css variables * [My Site Migration] user status feature (Part -4) (tests) (#977) * add integration tests for user-status components * fix set prop error and modify test case in status modal * add unit test for status route and component * add unit test for dateConversion, redirectAuth utils * fix: update test for user status, remove redirectAuth test * fix: status naming in user status component test --------- Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com> Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> * migrate from yarn to pnpm package manager (#991) * feat: migrate from yarn to pnpm package manager * docs: update documentation for pnpm migration * chore: remove unrelated changes to live.js * chore: restore helpful comments in CI workflow * chore: trigger CI * chore: trigger CI * feat: notifications page * fix: linting issues * fix: lint issue on router file --------- Co-authored-by: Mayank Bansal <mayankbansal125@gmail.com> Co-authored-by: Suvidh-kaushik <127885995+Suvidh-kaushik@users.noreply.github.com> Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com> Co-authored-by: DEVASHISH <devashish.cs025@gmail.com>

* Merge pull request #983 from MayankBansal12/migrate/user-status-pr-1 [My Site Migration] user status feature (Part - 1) * [My Site Migration] migration of profile page [PR-2] (#979) * basic setup and images and svg file * profile route and controller * changed urls.js file * reverted sinon package and fixed css * fixes of urls and yarn.lock and package.json file * changed toast import * moved profile fields to inside constants * resolve merge conflicts * [My Site Migration] user status feature (Part - 2) (#984) * feat: add user status modal, controller for status * refactor: use constants for messages, urls, modify naming * chore: remove extra user_states in status modal * refactor: get current status method in status modal * refactor: status update for dev method * test: simulate mock inViewport for members data test --------- Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> * [My Site Migration] user status feature (Part - 3) (css) (#985) * feat: add css styles for user status component and modal * fix: styles for user status, status modal for mobile responsiveness * fix: remove duplicate css variables * [My Site Migration] user status feature (Part -4) (tests) (#977) * add integration tests for user-status components * fix set prop error and modify test case in status modal * add unit test for status route and component * add unit test for dateConversion, redirectAuth utils * fix: update test for user status, remove redirectAuth test * fix: status naming in user status component test --------- Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com> Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> * migrate from yarn to pnpm package manager (#991) * feat: migrate from yarn to pnpm package manager * docs: update documentation for pnpm migration * chore: remove unrelated changes to live.js * chore: restore helpful comments in CI workflow * chore: trigger CI * chore: trigger CI * feat: notifications page * fix: linting issues * fix: lint issue on router file * feat: notitications page test cases * feat: add data-test-id * resolve: comments * fix: data test id * remove: unwanted template tests * feat: add route test cases * fix: rebundent test cases * remove: unused data test ids * remove: test cases --------- Co-authored-by: Mayank Bansal <mayankbansal125@gmail.com> Co-authored-by: Suvidh-kaushik <127885995+Suvidh-kaushik@users.noreply.github.com> Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com> Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com> Co-authored-by: DEVASHISH <devashish.cs025@gmail.com>

Devashish08 added 2 commits January 31, 2025 21:11

feat: migrate from yarn to pnpm package manager

222d797

docs: update documentation for pnpm migration

1d5cb4b

MayankBansal12 reviewed Jan 31, 2025

View reviewed changes

app/controllers/live.js Show resolved Hide resolved

Devashish08 requested a review from MayankBansal12 January 31, 2025 18:59

Devashish08 added 2 commits February 1, 2025 16:01

Merge branch 'develop' into chore/migrate-to-pnpm

c7c3e11

chore: remove unrelated changes to live.js

132f705

tejaskh3 previously approved these changes Feb 1, 2025

View reviewed changes

.github/workflows/continuous-integration.yml Show resolved Hide resolved

chore: restore helpful comments in CI workflow

941347e

Devashish08 dismissed tejaskh3’s stale review via 941347e February 1, 2025 11:51

Devashish08 requested a review from tejaskh3 February 1, 2025 12:17

Devashish08 closed this Feb 1, 2025

Devashish08 reopened this Feb 1, 2025

Achintya-Chatterjee assigned Devashish08 Feb 1, 2025

tejaskh3 previously approved these changes Feb 1, 2025

View reviewed changes

MayankBansal12 approved these changes Feb 1, 2025

View reviewed changes

chore: trigger CI

05ad867

Devashish08 changed the title ~~feat: migrate from yarn to pnpm package manager~~ migrate from yarn to pnpm package manager Feb 1, 2025

chore: trigger CI

13260b5

Devashish08 dismissed tejaskh3’s stale review via 13260b5 February 1, 2025 19:44

Merge branch 'develop' into chore/migrate-to-pnpm

b1988bd

pankajjs suggested changes Feb 2, 2025

View reviewed changes

.github/workflows/continuous-integration.yml Show resolved Hide resolved

.npmrc Show resolved Hide resolved

tejaskh3 approved these changes Feb 2, 2025

View reviewed changes

tejaskh3 requested a review from pankajjs February 2, 2025 10:47

pankajjs approved these changes Feb 2, 2025

View reviewed changes

Merge branch 'develop' into chore/migrate-to-pnpm

31db53a

Achintya-Chatterjee approved these changes Feb 3, 2025

View reviewed changes

iamitprakash approved these changes Feb 3, 2025

View reviewed changes

iamitprakash merged commit 449c1f3 into RealDevSquad:develop Feb 3, 2025
2 checks passed

Devashish08 deleted the chore/migrate-to-pnpm branch February 3, 2025 18:23

MayankBansal12 mentioned this pull request Mar 2, 2025

Update production deployment to use pnpm as package manager #1010

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate from yarn to pnpm package manager#991

migrate from yarn to pnpm package manager#991
iamitprakash merged 9 commits intoRealDevSquad:developfrom
Devashish08:chore/migrate-to-pnpm

Devashish08 commented Jan 31, 2025 •

edited

Loading

Uh oh!

RishiChaubey31 commented Jan 31, 2025

Uh oh!

Devashish08 commented Jan 31, 2025

Uh oh!

RishiChaubey31 commented Jan 31, 2025

Uh oh!

Uh oh!

Devashish08 commented Jan 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

pankajjs commented Feb 1, 2025

Uh oh!

Devashish08 commented Feb 2, 2025

Uh oh!

pankajjs left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Devashish08 commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Ticket Number:-

Description:

Add relevant Screenshot below ( e.g test coverage etc. )

Uh oh!

RishiChaubey31 commented Jan 31, 2025

Uh oh!

Devashish08 commented Jan 31, 2025

Uh oh!

RishiChaubey31 commented Jan 31, 2025

Uh oh!

Uh oh!

Devashish08 commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pankajjs commented Feb 1, 2025

Uh oh!

Devashish08 commented Feb 2, 2025

Uh oh!

pankajjs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Devashish08 commented Jan 31, 2025 •

edited

Loading

Devashish08 commented Jan 31, 2025 •

edited

Loading