This repository was archived by the owner on Apr 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Add write-only Invoice.couponIds
#795
Open
edmandiesamonte
wants to merge
4
commits into
master
Choose a base branch
from
invoice-write-coupons
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
41477c7
Add write-only `Invoice.couponIds`
3277580
Merge branch 'master' into invoice-write-coupons
edmandiesamonte 22ada88
Removed unncessary whitespace per PR feedback
3c88530
Merge branch 'invoice-write-coupons' of github.com:Rebilly/RebillyAPI…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -93,6 +93,25 @@ properties: | |||||
| items: | ||||||
| allOf: | ||||||
| - $ref: "#/components/schemas/InvoiceTax" | ||||||
| couponIds: | ||||||
| type: array | ||||||
| nullable: true | ||||||
| description: | | ||||||
| A list of coupons to redeem on the customer and restrict to this invoice. | ||||||
| Read more about [coupons here](https://help.rebilly.com/invoices-and-subscriptions/coupons-discounts). | ||||||
|
|
||||||
| This parameter respects the following logic: | ||||||
|
|
||||||
| - When not passed then applied coupons will not be changed. | ||||||
|
|
||||||
| - When empty array passed then all applied coupon redemptions will be canceled. | ||||||
|
|
||||||
| - When list of coupons is passed then not applied yet coupons will be applied, already applied coupons | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| will not change their state, applied coupons that are not presented in passed list will be canceled. | ||||||
| writeOnly: true | ||||||
| items: | ||||||
| type: string | ||||||
| description: Coupon ID | ||||||
| discounts: | ||||||
| type: array | ||||||
| description: Discounts applied | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.