-
Notifications
You must be signed in to change notification settings - Fork 4
feat(NGUI-474/33/42): Update New Modular Architecture for NGUI E2E Server #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
velias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like this modularization of the app, hope it somehow corresponds to the @jschuler proposal from his debug view PR.
I added few proposals and questions.
|
Hi @Hrithik-Gavankar, this branch is a bit out of date and needs a merge from main branch. Also, I didn't debug too much but I think it breaks the current way of running the test server locally, which is:
can you try and run this as baseline, to ensure it works and also after you add lightrail support? I would also suggest to make minimal lightrail changes first by:
Once we have this minimally added we can create followup PR with other improvements? WDYT |
|
Why are the same files and folder structures directly in the |
Thanks @velias for noticing this 👍, Those root-level modules were leftover from the migration and aren't used - the application only imports from |
- Refactor server to use LlamaStack integration - Add modular app/ structure with agents, routes, utils - Add Lightrail deployment configuration (.light folder) - Update config to use NGUI_MODEL and LLAMA_STACK_BASE_URL - Remove deprecated LangChain implementation - Add intelligent data filtering with generic_data_filter_agent - Update BUILD files for pants compatibility - Fix generate.py to use correct config variable names
36847b6 to
b21c8f5
Compare
velias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have liked to keep this. makes it easy to start the server locally
| } | ||
|
|
||
|
|
||
| @router.get("/model-info") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a useful endpoint for me
Migrated NGUI E2E server to Lightrail/LlamaStack with modular architecture.
Issues Resolved
✅ NGUI-442 - Fixed empty data_path and data arrays for nested/complex structures
✅ NGUI-433 - Added ability to mock backend data via REST API
Key Changes:
app/
├── agents/ # NGUI agent setup
├── data_sources/ # Inline, default, filtering
├── routes/ # API endpoints
├── utils/ # Validation, logging, responses
└── config.py # Configuration
Testing:
Local deployment
lightrail-local-cli build && lightrail-local-cli start
Test with default data