docs(announcement): enhance inline documentation#2738
Open
bennypowers wants to merge 2 commits intomainfrom
Open
docs(announcement): enhance inline documentation#2738bennypowers wants to merge 2 commits intomainfrom
bennypowers wants to merge 2 commits intomainfrom
Conversation
Enhanced inline documentation for rh-announcement component to improve developer experience and API understanding: - Enhanced `dismissable` property JSDoc with usage guidelines, accessibility notes, and when to show/hide the close button - Enhanced `imagePosition` property JSDoc with semantic meaning of positioning options, usage guidelines, and image sizing recommendations - Enhanced `colorPalette` property JSDoc with theme selection best practices and color contrast requirements - Added comprehensive inline documentation for all slots (default, image, cta) with content guidelines, character limits, and usage context - Added inline documentation for CSS parts (row, image) explaining their semantic purpose and styling role Note: Issue #2488 mentions a close() method which does not exist as public API. This PR documents the existing public API (dismissable property and close event). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Assisted-By: Claude <noreply@anthropic.com>
|
❌ Deploy Preview for red-hat-design-system failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Enhanced inline documentation for
rh-announcementcomponent to improve developer experience and API understanding, following the documentation standards established in PR #2548 forrh-progress-stepper.Testing Instructions
This documentation was created with assistance from LLM tools. Reviewers MUST carefully verify the semantic meaning and design system accuracy of all new documentation.
Please check that the enhanced documentation:
Specific sections to review:
1.
dismissableproperty (lines 40-58)2.
imagePositionproperty (lines 60-78)3.
colorPaletteproperty (lines 37-51)4. Inline slot documentation (lines 125-182)
5. Inline CSS part documentation (lines 111-121)
Notes to Reviewers
About Issue #2488
Issue #2488 mentions a
close()method that is missing documentation. However, after investigation:close()method exists in rh-announcementdismissablepropertydismissable=true) that fires a cancelablecloseevent#closeHandler()method (not part of public API)This PR documents the existing public API including:
dismissableproperty that controls the close buttoncloseevent that fires when users dismiss the announcementRecommendation: Issue #2488 should be updated or closed as the referenced
close()method does not exist as public API.Documentation Format
Following the project standard:
Addresses issue #2488 (with clarification about non-existent close() method)
🤖 Generated with Claude Code