Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 257 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
this PR should improve the inline docs for chip and chip group as well - in fact, it should primarily be about improving the jsdoc
see https://github.com/RedHat-UX/red-hat-design-system/pulls?q=is%3Aopen+is%3Apr+author%3Abennypowers+enhance for examples
read guidelines for writing effective descriptions
remember: good documentation is an accessibility (cognitive) issue
marionnegp
left a comment
There was a problem hiding this comment.
Looks good! I left one small edit. The only other thing I noticed was the use of "component" that Benny's already called out.
I agree that improving the JSDoc is important. This PR is focused specifically on addressing the changes requested in #2804. Updates to the chip and chip-group JSDoc would be better handled in a separate, follow-up PR so we can give those changes the attention they deserve. |
What I did
<rh-chip>vs<rh-chip-group>Closes #2804
Testing Instructions
Notes to Reviewers
Big ups to Zack for reporting the issue and Potter for discovering it.