feat(drawer): adds <rh-drawer> - #3060
Open
zeroedin wants to merge 19 commits into
Open
Conversation
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 5b374be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Contributor
Documentation Health
|
| Category | Score | |
|---|---|---|
| Element description | 13/25 | |
| Attribute documentation | 20/20 | ✅ |
| Slot documentation | 15/15 | ✅ |
| CSS documentation | 15/15 | ✅ |
| Event documentation | 15/15 | ✅ |
| Demos | 0/0 | ❌ |
DrawerCloseEvent — 76/90 ✅
| Category | Score | |
|---|---|---|
| Element description | 11/25 | |
| Attribute documentation | 20/20 | ✅ |
| Slot documentation | 15/15 | ✅ |
| CSS documentation | 15/15 | ✅ |
| Event documentation | 15/15 | ✅ |
| Demos | 0/0 | ❌ |
DrawerThresholdEvent — 76/90 ✅
| Category | Score | |
|---|---|---|
| Element description | 11/25 | |
| Attribute documentation | 20/20 | ✅ |
| Slot documentation | 15/15 | ✅ |
| CSS documentation | 15/15 | ✅ |
| Event documentation | 15/15 | ✅ |
| Demos | 0/0 | ❌ |
rh-drawer (RhDrawer) — 77/100 ⚠️
| Category | Score | |
|---|---|---|
| Element description | 17/25 | |
| Attribute documentation | 20/20 | ✅ |
| Slot documentation | 13/15 | ✅ |
| CSS documentation | 4/15 | ❌ |
| Event documentation | 13/15 | ✅ |
| Demos | 10/10 | ✅ |
Recommendations:
- DrawerThresholdEvent: use RFC 2119 keywords (MUST, SHOULD, AVOID) to clarify requirements (Element description, +5 pts)
- DrawerCloseEvent: use RFC 2119 keywords (MUST, SHOULD, AVOID) to clarify requirements (Element description, +5 pts)
- rh-drawer: add descriptions to all CSS parts (CSS documentation, +5 pts)
- DrawerOpenEvent: use RFC 2119 keywords (MUST, SHOULD, AVOID) to clarify requirements (Element description, +5 pts)
- DrawerOpenEvent: mention accessibility considerations (ARIA, screen reader, WCAG) (Element description, +4 pts)
bennypowers
requested changes
Jul 2, 2026
| this.#resizeObserver = new ResizeObserver(entries => { | ||
| const [entry] = entries; | ||
| if (entry) { | ||
| const narrow = entry.contentBoxSize[0].inlineSize < 992; |
Member
There was a problem hiding this comment.
does this need to be configurable per spec?
Collaborator
Author
There was a problem hiding this comment.
That is definitely a question for @coreyvickery prior iteration allowed it to be via tshirt sizes, curernt figma suggests only 992.
Contributor
|
Size Change: +7.15 kB (+2.22%) Total Size: 329 kB 📦 View Changed
ℹ️ View Unchanged
|
zeroedin
marked this pull request as ready for review
July 9, 2026 14:12
coreyvickery
requested changes
Jul 10, 2026
coreyvickery
left a comment
coreyvickery
left a comment
Collaborator
There was a problem hiding this comment.
@zeroedin Let's remove any box shadows on the actual tray, but not the button. Ready to ship after that.
zeroedin
force-pushed
the
feat/rh-drawer-take-three
branch
from
July 27, 2026 21:28
a2709a3 to
4eb7ec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
<rh-drawer>, a side panel component for supplementary content or navigation, aligned with the rh-drawer Figma spec.rh-navigation-primary(for discussion) andrh-navigation-vertical.Supersedes: #2850
The component was simplified significantly from the previous attempt:
Testing Instructions
Notes to Reviewers
The drawer responds to its nearest ancestor with container-type: inline-size. Without one, it always behaves as an overlay. This was one of the refactorings from the previous drawer. I'm still not convinced this implementation gets it right, as it almost always forces full pattern usage, external container + drawer. In my opinion, a drawer is both the panel (the face and knob) and the box for the contents (holding the clothes). Doing so would allow for easier implimenation I think.