docs(next-prev): adding <uxdot-pathfinder> component and adding next/prev links to Getting Started - #3100
docs(next-prev): adding <uxdot-pathfinder> component and adding next/prev links to Getting Started#3100markcaron wants to merge 10 commits into
<uxdot-pathfinder> component and adding next/prev links to Getting Started#3100Conversation
…ev links to getting started
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
Size Change: +1.51 kB (+0.47%) Total Size: 323 kB 📦 View Changed
ℹ️ View Unchanged
|
Documentation HealthNo relevant changes in this PR. |
zeroedin
left a comment
There was a problem hiding this comment.
Links Guiding Through Material
adamjohnson
left a comment
There was a problem hiding this comment.
Definitely look into the reflow issue.
Also, pending further instruction from design, IMO instituting some min-inline-size and max-inline-size's would probably tighten up the design.
There was a problem hiding this comment.
FYI if you scrunch your browser down to 320px, this component causes horizontal scrollbars. This violates WCAG 1.4.10 Reflow (AA).
I would recommend hiding the rh-icon arrows at narrow browser widths. Designers may have input as to whether these links should stack at small viewport widths.
There was a problem hiding this comment.
@markcaron These changes should solve everything. cc @adamjohnson
- Change title and page name text sizes to
--rh-font-size-body-text-sm(14px) - Change left and right padding to
--rh-space-lg(16px) - Remove
min-align-sizefrom CSS - Align
Previousto left - Align
Nextto right
Screenshot at 320px
|
@markcaron Not sure if I'm seeing the changes I requested in regards to text size and padding. |
|
@coreyvickery my fault. Try again. |
coreyvickery
left a comment
There was a problem hiding this comment.
@markcaron Let's remove the 64px padding on top and we're good to go.
What I did
<uxdot-pathfinder>Testing Instructions