fix(table): add css token fallbacks - #3204
Open
adamjohnson wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 46f9238 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: 0 B Total Size: 323 kB ℹ️ View Unchanged
|
Contributor
Documentation HealthNo relevant changes in this PR. |
adamjohnson
marked this pull request as ready for review
September 3, 2026 19:00
PR Summary by QodoAdd theme-adaptive fallbacks for table link colors
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
light-dark()fallbacks for--rh-color-interactive-primary-defaultand--rh-color-interactive-primary-hoverinrh-table-lightdom.css. Shadow CSS was already clean because<rh-table>is@themable.<rh-table>missing css var fallbacks #3180.Testing Instructions
npm run devin the RHDS directory. The element demo server starts at http://localhost:8000.npm run lintin the RHDS directory.fix/css-var-fallbacks.Notes to Reviewers
Other elements still fail
rhds/require-token-fallback, so Netlify will not publish a deploy preview for this PR. We will likely have to merge this PR with these errors. Don't get led astray by the errors. We will see these lint errors until we have tackled all of #3119.