fix: correct dark value in getLightDarkValue() for --rh-color-surface

[zeroedin]

What I did

• Corrected the output for --rh-color-surface in getLightDarkValue().

Because rh-color-surface has many values, not just two possible, we need to grab the first and last in the array instead of just destructuring the array expecting the first two to be correct.

Closes RedHat-UX/red-hat-design-system#2440

[changeset-bot]

🦋 Changeset detected

Latest commit: e9a7a21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@rhds/tokens	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for red-hat-design-tokens ready!

Name	Link
🔨 Latest commit	e9a7a21
🔍 Latest deploy log	https://app.netlify.com/projects/red-hat-design-tokens/deploys/6883ab670ecaba0008c64b99
😎 Deploy Preview	https://deploy-preview-170--red-hat-design-tokens.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[hellogreg]

@bennypowers

[bennypowers]

I got this in the DP for --rh-color-surface's values:

<samp style="background-color: var(--rh-color-surface-lightest);"></samp>
<samp style="background-color: var(--rh-color-surface-lighter);"></samp>

https://deploy-preview-170--red-hat-design-tokens.netlify.app/#color-surface

likewise for surface status colors

[zeroedin]

I got this in the DP for --rh-color-surface's values:
...
likewise for surface status colors

Interesting, it builds css/default-theme.css correctly.

  --rh-color-surface:
    light-dark(
      var(--rh-color-surface-lightest, #ffffff),
      var(--rh-color-surface-darkest, #151515)
    );

As well as js/tokens.ts (where it is broken in main)

"--rh-color-surface": "light-dark(var(--rh-color-surface-lightest, #ffffff), var(--rh-color-surface-darkest, #151515))",

I'll look into the docs code and take a look at how it's reading the values and maybe it's doing the same thing by grabbing the first two, rather than the first and last.

[bennypowers]

if you can validate the built package (with the npm pack, untar, copy trick) against rhds docs, that's good enough for me.

[zeroedin]

@bennypowers docs fixed andnpm pack install validated over on RHDS: