Conversation
|
✅ Deploy Preview for red-hat-design-tokens ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@coreyvickery regarding the docs: anything new going into this repo needs to have top notch, fully realized docs, like we discussed regarding elements, etc |
|
@bennypowers I don't think I understand. I thought we usually just add new tokens to some tables in the Am I missing something? |
|
So, all of that in the token section on the website actually derives from these yaml files. Meaning the documentation content for tokens doesn't live in the docs folder, in the UX.Repo, it actually lives here. That's important because the website isn't the only context in which the documentation for those tokens is relevant. For example, we can add the tokens that are used in an element to the custom elements manifest and then use that to inform an MCP server about what kinds of elements to use and what kinds of patterns and what kinds of design tokens to use. So in order for any of that to happen, we have to thoroughly document the design tokens, like we discussed previously, here in the tokens repo, when we're adding them. In other words, this repository and these YAML files have to be the single source of truth about everything for our design tokens, including extensive documentation. |
Anything have this yet? An example I can look at? |
adamjohnson
left a comment
There was a problem hiding this comment.
--rh-color-icon-status-disabled light scheme color change.
| disabled: | ||
| _: | ||
| $value: | ||
| - '{color.gray.50}' |
There was a problem hiding this comment.
| - '{color.gray.50}' | |
| - '{color.gray.40}' |
--rh-color-icon-status-disabled on light color schemes has been changed to gray-40 per @coreyvickery. RedHat-UX/red-hat-design-system#2596 and RedHat-UX/red-hat-design-system#2593 are related PRs.
| $description: >- | ||
| TBD | ||
| on-light: | ||
| $value: '{color.gray.50}' |
There was a problem hiding this comment.
| $value: '{color.gray.50}' | |
| $value: '{color.gray.40}' |
See above comment.
Closes #168