Skip to content

feat: new tokens#171

Draft
bennypowers wants to merge 2 commits intomainfrom
feat/new-tokens
Draft

feat: new tokens#171
bennypowers wants to merge 2 commits intomainfrom
feat/new-tokens

Conversation

@bennypowers
Copy link
Member

Closes #168

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2025

⚠️ No Changeset found

Latest commit: 22e72cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for red-hat-design-tokens ready!

Name Link
🔨 Latest commit 22e72cc
🔍 Latest deploy log https://app.netlify.com/projects/red-hat-design-tokens/deploys/68e40577b8371c0008b2e729
😎 Deploy Preview https://deploy-preview-171--red-hat-design-tokens.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bennypowers
Copy link
Member Author

@coreyvickery regarding the docs: anything new going into this repo needs to have top notch, fully realized docs, like we discussed regarding elements, etc

@coreyvickery
Copy link
Collaborator

@bennypowers I don't think I understand. I thought we usually just add new tokens to some tables in the Tokens section.

Am I missing something?

@bennypowers
Copy link
Member Author

bennypowers commented Jul 11, 2025

So, all of that in the token section on the website actually derives from these yaml files.

Meaning the documentation content for tokens doesn't live in the docs folder, in the UX.Repo, it actually lives here.

That's important because the website isn't the only context in which the documentation for those tokens is relevant.

For example, we can add the tokens that are used in an element to the custom elements manifest and then use that to inform an MCP server about what kinds of elements to use and what kinds of patterns and what kinds of design tokens to use.

So in order for any of that to happen, we have to thoroughly document the design tokens, like we discussed previously, here in the tokens repo, when we're adding them.

In other words, this repository and these YAML files have to be the single source of truth about everything for our design tokens, including extensive documentation.

@coreyvickery
Copy link
Collaborator

@bennypowers

top notch, fully realized docs, like we discussed regarding elements, etc

Anything have this yet? An example I can look at?

Copy link
Contributor

@adamjohnson adamjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--rh-color-icon-status-disabled light scheme color change.

disabled:
_:
$value:
- '{color.gray.50}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '{color.gray.50}'
- '{color.gray.40}'

--rh-color-icon-status-disabled on light color schemes has been changed to gray-40 per @coreyvickery. RedHat-UX/red-hat-design-system#2596 and RedHat-UX/red-hat-design-system#2593 are related PRs.

$description: >-
TBD
on-light:
$value: '{color.gray.50}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$value: '{color.gray.50}'
$value: '{color.gray.40}'

See above comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[epic] [feat] New tokens (to align to Figma variables)

4 participants