-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ask-red-hat): add <rhx-ask-red-hat>
#29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging/acheron
Are you sure you want to change the base?
Conversation
|
|
Size Change: +3.08 kB (+14.72%) Total Size: 24 kB
ℹ️ View Unchanged
|
✅ Deploy Preview for rhds-extensions ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
What I did
<cp-ask-red-hat>to<rhx-ask-red-hat><rhx-ask-red-hat-button>. TBD on if this component is necessary, but a similar button is being used on docs.redhat.com; it would be nice to encapsulate the style for reuse.<rhx-ask-red-hat>this is in contrast to the currently existing<cp-ask-red-hat>which requires authentication to display.<rhx-ask-red-hat>component will be visible to all users, unlike its predecessor.Updated elements / docs to support color scheme tokenscherry picked out of this PR and merged in docs: updates, dev server, color scheme, documentation #36Closes #30
TODO:
<rhx-ask-red-hat>to<rhx-ask-red-hat-link>with the addition of<rhx-ask-red-hat-button>to avoid confusion. Or are we deleting both components and focus on implementation in RHDS.Testing Instructions
Notes to Reviewers
Becauserhx-ask-red-hatrequires an authentication source, the component is difficult to test. Copying and pasting token values and userId from a primer authentication and adding those to the component is the only viable option at this time.This is no longer an issue, as the authentication is being removed.