Skip to content

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Jul 9, 2025

What I did

  1. Migrated <cp-ask-red-hat> to <rhx-ask-red-hat>
  2. Added <rhx-ask-red-hat-button>. TBD on if this component is necessary, but a similar button is being used on docs.redhat.com; it would be nice to encapsulate the style for reuse.
  3. Authentication was removed from <rhx-ask-red-hat> this is in contrast to the currently existing <cp-ask-red-hat> which requires authentication to display. <rhx-ask-red-hat> component will be visible to all users, unlike its predecessor.
  4. Updated elements / docs to support color scheme tokens cherry picked out of this PR and merged in docs: updates, dev server, color scheme, documentation #36

Closes #30

TODO:

  • Determine if we should rename <rhx-ask-red-hat> to <rhx-ask-red-hat-link> with the addition of <rhx-ask-red-hat-button> to avoid confusion. Or are we deleting both components and focus on implementation in RHDS.
  • Add tests
  • Add changeset
  • Code review
  • Accessibility review

Testing Instructions

  1. View Deploy preview for link
  2. View Deploy preview for button

Notes to Reviewers

Because rhx-ask-red-hat requires an authentication source, the component is difficult to test. Copying and pasting token values and userId from a primer authentication and adding those to the component is the only viable option at this time.

This is no longer an issue, as the authentication is being removed.

@zeroedin zeroedin self-assigned this Jul 9, 2025
@zeroedin zeroedin added the feature Net new component or feature label Jul 9, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025

⚠️ No Changeset found

Latest commit: d8f0c70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

Size Change: +3.08 kB (+14.72%) ⚠️

Total Size: 24 kB

Filename Size Change
./elements.js 103 B +27 B (+35.53%) 🚨
./elements/rhx-ask-red-hat-button/rhx-ask-red-hat-button.js 1.82 kB +1.82 kB (new file) 🆕
./elements/rhx-ask-red-hat/rhx-ask-red-hat.js 1.24 kB +1.24 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./elements/rhx-grid/rhx-grid-item.js 419 B
./elements/rhx-grid/rhx-grid.js 692 B
./uxdot/uxdot-best-practice.js 812 B
./uxdot/uxdot-color-scheme-picker.js 1.56 kB
./uxdot/uxdot-copy-button.js 1.24 kB
./uxdot/uxdot-copy-permalink.js 1.1 kB
./uxdot/uxdot-demo.js 1.38 kB
./uxdot/uxdot-example.js 1.14 kB
./uxdot/uxdot-feedback.js 837 B
./uxdot/uxdot-header.js 1.02 kB
./uxdot/uxdot-masthead.js 1.36 kB
./uxdot/uxdot-search.js 2.39 kB
./uxdot/uxdot-sidenav.js 2.69 kB
./uxdot/uxdot-spacer-tokens-table.js 2.46 kB
./uxdot/uxdot-toc.js 1.8 kB

compressed-size-action

@zeroedin zeroedin moved this to In Progress in Red Hat Extensions Jul 9, 2025
@zeroedin zeroedin added this to the acheron release milestone Jul 9, 2025
@zeroedin zeroedin marked this pull request as ready for review August 29, 2025 19:52
@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for rhds-extensions ready!

Name Link
🔨 Latest commit d8f0c70
🔍 Latest deploy log https://app.netlify.com/projects/rhds-extensions/deploys/68b9ed9a6a75f00008fc0c22
😎 Deploy Preview https://deploy-preview-29--rhds-extensions.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zeroedin zeroedin added the blocked Issue is blocked label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Issue is blocked feature Net new component or feature

Projects

Development

Successfully merging this pull request may close these issues.

2 participants