Update dependency fastapi to v0.129.1#19
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Summary by CodeRabbit
WalkthroughFastAPI dependency version is bumped from 0.129.0 to 0.129.1 across both dependency specification files. No functional changes, control flow modifications, or error handling updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 10 10
Lines 199 199
Branches 6 6
=======================================
Hits 173 173
Misses 25 25
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@requirements.txt`:
- Line 1: The requirements declare fastapi==0.129.1 but setup.cfg's
python_requires is too low (python_requires = >=3.6), causing installs on
3.6–3.9 to fail; fix by either updating setup.cfg's python_requires to ">=3.10"
(change the python_requires setting) or by selecting a FastAPI release
compatible with the current floor (replace fastapi==0.129.1 in requirements.txt
with a version that supports >=3.6/3.7/3.8/3.9), and ensure the change is
reflected consistently in both requirements.txt and setup.cfg.
---
Duplicate comments:
In `@setup.cfg`:
- Around line 16-18: The install_requires block (install_requires,
uvicorn[standard] >= 0.31.1, fastapi ==0.129.1) lacks a Python version
compatibility declaration; add a python_requires entry in setup.cfg (for example
python_requires = >=3.8,<4) to enforce supported Python versions and, if needed,
adjust the pinned uvicorn/fastapi versions to ones that are compatible with that
python_requires range.
| @@ -1,4 +1,4 @@ | |||
| fastapi==0.129.0 | |||
| fastapi==0.129.1 | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check FastAPI 0.129.1 Python version requirements from PyPI
curl -s https://pypi.org/pypi/fastapi/0.129.1/json | jq -r '.info.requires_python'Repository: RedHatInsights/ccx-upgrades-inference
Length of output: 87
🏁 Script executed:
# Check the declared Python floor in setup.cfg
if [ -f setup.cfg ]; then
grep -A2 "python_requires" setup.cfg
else
echo "setup.cfg not found"
fiRepository: RedHatInsights/ccx-upgrades-inference
Length of output: 155
Update setup.cfg python_requires or downgrade FastAPI.
FastAPI 0.129.1 requires Python ≥3.10, but setup.cfg declares python_requires = >=3.6. This creates a critical mismatch—installations on Python 3.6–3.9 will fail. Either update python_requires to >=3.10 in setup.cfg or select a FastAPI version compatible with your declared Python floor.
🧰 Tools
🪛 OSV Scanner (2.3.3)
[HIGH] 1-1: urllib3 1.26.20: urllib3 streaming API improperly handles highly compressed data
[HIGH] 1-1: urllib3 1.26.20: Decompression-bomb safeguards bypassed when following HTTP redirects (streaming API)
[HIGH] 1-1: urllib3 1.26.20: urllib3 allows an unbounded number of links in the decompression chain
[HIGH] 1-1: urllib3 1.26.20: urllib3 redirects are not disabled when retries are disabled on PoolManager instantiation
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@requirements.txt` at line 1, The requirements declare fastapi==0.129.1 but
setup.cfg's python_requires is too low (python_requires = >=3.6), causing
installs on 3.6–3.9 to fail; fix by either updating setup.cfg's python_requires
to ">=3.10" (change the python_requires setting) or by selecting a FastAPI
release compatible with the current floor (replace fastapi==0.129.1 in
requirements.txt with a version that supports >=3.6/3.7/3.8/3.9), and ensure the
change is reflected consistently in both requirements.txt and setup.cfg.
1 participant
This PR contains the following updates:
==0.129.0->==0.129.1Release Notes
fastapi/fastapi (fastapi)
v0.129.1Compare Source
Fixes
"contentMediaType": "application/octet-stream"instead of"format": "binary". PR #14953 by @tiangolo.Docs
Translations
Internal
masterbranch and when run by scheduler. PR #14940 by @YuriiMotov.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.